fix(rangeInput): clear input when refinement is cleared (#4429)

algolia · Jun 9, 2020 · a2c7663 · a2c7663
1 parent 0c75437
commit a2c7663
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/components/RangeInput/RangeInput.js b/src/components/RangeInput/RangeInput.js
@@ -58,7 +58,7 @@ class RangeInput extends Component {
               min={min}
               max={max}
               step={step}
-              value={minValue}
+              value={minValue ?? ''}
               onInput={this.onInput('min')}
               placeholder={min}
               disabled={isDisabled}
@@ -81,7 +81,7 @@ class RangeInput extends Component {
               min={min}
               max={max}
               step={step}
-              value={maxValue}
+              value={maxValue ?? ''}
               onInput={this.onInput('max')}
               placeholder={max}
               disabled={isDisabled}

diff --git a/src/components/RangeInput/__tests__/__snapshots__/RangeInput-test.js.snap b/src/components/RangeInput/__tests__/__snapshots__/RangeInput-test.js.snap
@@ -20,6 +20,7 @@ exports[`RangeInput expect to render 1`] = `
         placeholder={0}
         step={1}
         type="number"
+        value=""
       />
     </label>
     <Template
@@ -52,6 +53,7 @@ exports[`RangeInput expect to render 1`] = `
         placeholder={500}
         step={1}
         type="number"
+        value=""
       />
     </label>
     <Template
@@ -98,6 +100,7 @@ exports[`RangeInput expect to render with disabled state 1`] = `
         placeholder={480}
         step={1}
         type="number"
+        value=""
       />
     </label>
     <Template
@@ -130,6 +133,7 @@ exports[`RangeInput expect to render with disabled state 1`] = `
         placeholder={20}
         step={1}
         type="number"
+        value=""
       />
     </label>
     <Template
@@ -256,6 +260,7 @@ exports[`RangeInput willReceiveProps expect to update the empty state from given
         placeholder={0}
         step={1}
         type="number"
+        value=""
       />
     </label>
     <Template
@@ -288,6 +293,7 @@ exports[`RangeInput willReceiveProps expect to update the empty state from given
         placeholder={500}
         step={1}
         type="number"
+        value=""
       />
     </label>
     <Template