Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 3.4.1: "warning: redefining 'object_id' may cause serious problems" #509

Closed
guillaumewrobel opened this issue Jan 1, 2025 · 6 comments · Fixed by algolia/api-clients-automation#4381
Closed

Ruby 3.4.1: "warning: redefining 'object_id' may cause serious problems" #509

guillaumewrobel opened this issue Jan 1, 2025 · 6 comments · Fixed by algolia/api-clients-automation#4381

Comments

@guillaumewrobel
Copy link

Ruby version: 3.4.1
Algolia gem version: 3.10.2

/algolia/models/ingestion/push_task_records.rb:10: warning: redefining 'object_id' may cause serious problems
/algolia/models/recommend/bought_together_query.rb:23: warning: redefining 'object_id' may cause serious problems
/algolia/models/recommend/hide_consequence_object.rb:11: warning: redefining 'object_id' may cause serious problems
/algolia/models/recommend/looking_similar_query.rb:23: warning: redefining 'object_id' may cause serious problems
/algolia/models/recommend/promote_consequence_object.rb:11: warning: redefining 'object_id' may cause serious problems
/algolia/models/recommend/recommend_hit.rb:11: warning: redefining 'object_id' may cause serious problems
/algolia/models/recommend/recommend_rule.rb:13: warning: redefining 'object_id' may cause serious problems
/algolia/models/recommend/related_query.rb:23: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/consequence_hide.rb:11: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/dictionary_entry.rb:11: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/get_objects_request.rb:14: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/hit.rb:11: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/promote_object_id.rb:11: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/rule.rb:11: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/save_object_response.rb:16: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/synonym_hit.rb:11: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/updated_at_with_object_id_response.rb:17: warning: redefining 'object_id' may cause serious problems
/algolia/models/search/user_hit.rb:22: warning: redefining 'object_id' may cause serious problems
@bvogel
Copy link

bvogel commented Jan 7, 2025

still persistent in 3.11.0

@bvogel
Copy link

bvogel commented Jan 10, 2025

this is how others have dealt with comparable issues: microsoftgraph/msgraph-sdk-ruby#92 (comment)

@guillaumewrobel
Copy link
Author

hey @shortcuts , do you plan to work on this issue?

@guillaumewrobel
Copy link
Author

Or maybe @kombucha @DevinCodes could you look at it?

@millotp millotp mentioned this issue Jan 21, 2025
Merged
@guillaumewrobel
Copy link
Author

great work @millotp 🙏 Do you plan to bump a release soon?

@millotp
Copy link
Contributor

millotp commented Jan 23, 2025

Hey @guillaumewrobel, the fix has been released in 3.12.0 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ruby): rename object_id reserved word to algolia_object_id algolia/api-clients-automation
3 participants
@bvogel @millotp @guillaumewrobel