-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests/Formatting/Linting #23
Comments
I agree with all of this. We are using black for linting, and had some internal discussions about moving to ruff. @gmberton has been leading that effort and may have some thoughts. The tests you mentioned would be very welcome. I do not have a lot of experience with pytest but would be happy to learn. We have some basic, self run tests via Perhaps we could add GH Actions as well so these are run automatically? |
Agree on all you both said. It would be good to add test, as the current ones can surely be improved. I also don't have experience with pytest so @isaaccorley your help would be more than welcome. |
Cool yeah I'll work on adding some github actions similar to those used in TorchGeo. I transitioned from black/isort/flake8/pyupgrade to ruff recently and never looked back. It simplifies a lot of config setup in pyproject.toml also. |
This repo needs some tests for style and that each model still works (make sure urls aren't down, models still load, etc.). I recommend ruff for formatting/linting and pytest.
Any interest in me adding these?
The text was updated successfully, but these errors were encountered: