Guard against namespace aliases with no namespace #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When completing keywords, the presence of double colons and a slash assumed that there was a namespace alias separating the two. We catch the (infrequent) situation of that not being the case, as this threw an error when the user was typing
|
Much appreciated, thank you! |
|
@alexander-yakushev Can we get a bugfix release? |
|
Only for you, Bozhidar 😄 Grab 0.3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When completing keywords, the presence of double colons and a slash
assumed that there was a namespace alias separating the two. We catch
the (infrequent) situation of that not being the case, as this threw
an error when the user was typing
re: #46