Cannot read property 'parse' of undefined (at line 29 of blanket.js)

[mapio]

Serving the test dir and opening /backbone-koans/ in the browser result in the console reporting the error that is the subject of this issue. The culprit seems to be

blanket/dist/qunit/blanket.js

Line 29 in 11f1a92

var parse = require('esprima').parse;

a missing library.

[warpig9]

I think you should built the project first. Follow the steps in Roll your own section.

[mapio]

I don't think you are right.

First of all, that file is a dist directory https://github.com/alex-seville/blanket/tree/HEAD/dist/qunit that suggest it already has been built.

Second, the same error (albeit at a different line number) happens if using the minified file in the same directory – exactly what one is suggested to do by the instruction in http://blanketjs.org/.

Finally, the error does not happen using https://raw.githubusercontent.com/alex-seville/blanket/89266afe70ea733592f5d51f213657d98e19fc0a/dist/qunit/blanket.js (without building).

So it seems that, probably by mistake, the wrong (unbuilt) file has been committed to the repo (in the dist directory).

[warpig9]

Yes, the file blanket.js(65kb) in /dist/qunit is unbuilt. It became 200kb after I built it and that's why I suggest you should built it by yourself.
BTW, from the source code I saw that blanket needs a 3rd-party parser(Esprima or other parsers), and the building work will import the parser in the target file, that's why blanket can do all the job in the browser without any nodejs dependency during runtime.

[yangzhaox]

I met the same issue. The files is /dist/qunit should be updated.

[mapio]

@warpig9 I can absolutely agree that committing a file that is built from other files in the repo is quite a bad idea (given its size, but not only); it is a common best practice not to do so, reported even on some GitHub guide http://kbroman.org/github_tutorial/pages/routine.html "[d]on’t include files that are derived from other files in the repository".

You should also consider that:

• the http://blanketjs.org/ home page explicitly instructs you that "[t]he only file you need is blanket.js [d]ownload the library and reference it in your test runner" and points to (the currently not working) https://raw.github.com/alex-seville/blanket/master/dist/qunit/blanket.min.js and does not mention at all that one should download the source and build it himself;
• the same holds for the "Getting Started Guide (browser version)" https://github.com/alex-seville/blanket/blob/master/docs/getting_started_browser.md also pointing to (the currently not working) https://raw.github.com/alex-seville/blanket/master/dist/qunit/blanket.min.js and does not mention at all again the one needs to build such file.

So I think you either to:

• update the dist directory to contain working (built) files,
• remove the dist directory and update the documents where it is said that it's enough to download files from such dir.

[socketwiz]

I just ran into this as well. Installing through npm has a similar problem. I had to clone the repo and rebuild the dist directory as well in order to get past it.

[magwas]

Same problem here. You should either keep your dist up-to date and built, or remove/rename it.

You know, we users are lazy. So lazy you should treat me as dumb. Because we have our own host of dependencies, and want to focus on our own project. So please provide ready-to-use package (in our case that one blanket.min.js is okay).
I revert to https://raw.githubusercontent.com/alex-seville/blanket/89266afe70ea733592f5d51f213657d98e19fc0a/dist/qunit/blanket.js for the time being.

[stefaneg]

Backed out of 1.2.0 due to this issue. Any fix on the horizon?

[mapio]

@stefaneg as you see in #541 (comment) @warpig9 does not consider this a bug :( so no fix will be ever provided…

[stefaneg]

Either the documentation has to change or the code distribution. While they are not in sync, this is definitely a bug. I would suggest that the right thing to do is to publish a built blanket.js in a npm package, and update the docs accordingly.

[mapio]

@stefaneg 👍

[louisatome]

+1 for @mapio arguments. That is really disturbing when you follow the docs and it doesn't work as expected. The docs should mention that or the file should be updated.