Skip to content

Commit

Permalink
Merge pull request #474 from wh1t3w0lf21/development
Browse files Browse the repository at this point in the history 
replace 'nodeValue' with 'value' (fixes #461)
  • Loading branch information
@alex-seville
alex-seville committed Mar 23, 2015
2 parents 16951b9 + cd9d80a commit d647f2b
Show file tree
Hide file tree
Showing 8 changed files with 59 additions and 59 deletions.
28 changes: 14 additions & 14 deletions dist/jasmine/blanket_jasmine.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5077,36 +5077,36 @@ blanket.defaultReporter = function(coverage) {
toArray.call(scripts[scripts.length - 1].attributes)
.forEach(function(es) {
if (es.nodeName === "data-cover-only") {
newOptions.filter = es.nodeValue;
newOptions.filter = es.value;
}

if (es.nodeName === "data-cover-never") {
newOptions.antifilter = es.nodeValue;
newOptions.antifilter = es.value;
}

if (es.nodeName === "data-cover-reporter") {
newOptions.reporter = es.nodeValue;
newOptions.reporter = es.value;
}

if (es.nodeName === "data-cover-adapter") {
newOptions.adapter = es.nodeValue;
newOptions.adapter = es.value;
}

if (es.nodeName === "data-cover-loader") {
newOptions.loader = es.nodeValue;
newOptions.loader = es.value;
}

if (es.nodeName === "data-cover-timeout") {
newOptions.timeout = es.nodeValue;
newOptions.timeout = es.value;
}

if (es.nodeName === "data-cover-modulepattern") {
newOptions.modulePattern = es.nodeValue;
newOptions.modulePattern = es.value;
}

if (es.nodeName === "data-cover-reporter-options") {
try {
newOptions.reporter_options = JSON.parse(es.nodeValue);
newOptions.reporter_options = JSON.parse(es.value);
} catch (e) {
if (blanket.options("debug")) {
throw new Error("Invalid reporter options. Must be a valid stringified JSON object.");
Expand All @@ -5115,15 +5115,15 @@ blanket.defaultReporter = function(coverage) {
}

if (es.nodeName === "data-cover-testreadycallback") {
newOptions.testReadyCallback = es.nodeValue;
newOptions.testReadyCallback = es.value;
}

if (es.nodeName === "data-cover-customvariable") {
newOptions.customVariable = es.nodeValue;
newOptions.customVariable = es.value;
}

if (es.nodeName === "data-cover-flags") {
var flags = " " + es.nodeValue + " ";
var flags = " " + es.value + " ";

if (flags.indexOf(" ignoreError ") > -1) {
newOptions.ignoreScriptError = true;
Expand Down Expand Up @@ -5234,8 +5234,8 @@ blanket.defaultReporter = function(coverage) {
selectedScripts = toArray.call(document.scripts)
.filter(function(s) {
return toArray.call(s.attributes).filter(function(sn) {
return sn.nodeName === "src" && _blanket.utils.matchPatternAttribute(sn.nodeValue, filter) &&
(typeof antimatch === "undefined" || !_blanket.utils.matchPatternAttribute(sn.nodeValue, antimatch));
return sn.nodeName === "src" && _blanket.utils.matchPatternAttribute(sn.value, filter) &&
(typeof antimatch === "undefined" || !_blanket.utils.matchPatternAttribute(sn.value, antimatch));
}).length === 1;
});
} else {
Expand All @@ -5246,7 +5246,7 @@ blanket.defaultReporter = function(coverage) {
return _blanket.utils.qualifyURL(
toArray.call(s.attributes).filter(function(sn) {
return sn.nodeName === "src";
})[0].nodeValue);
})[0].value);
});

if (!filter) {
Expand Down
2 changes: 1 addition & 1 deletion dist/jasmine/blanket_jasmine.min.js
View file

Large diffs are not rendered by default.

28 changes: 14 additions & 14 deletions dist/mocha/blanket_mocha.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5077,36 +5077,36 @@ blanket.defaultReporter = function(coverage) {
toArray.call(scripts[scripts.length - 1].attributes)
.forEach(function(es) {
if (es.nodeName === "data-cover-only") {
newOptions.filter = es.nodeValue;
newOptions.filter = es.value;
}

if (es.nodeName === "data-cover-never") {
newOptions.antifilter = es.nodeValue;
newOptions.antifilter = es.value;
}

if (es.nodeName === "data-cover-reporter") {
newOptions.reporter = es.nodeValue;
newOptions.reporter = es.value;
}

if (es.nodeName === "data-cover-adapter") {
newOptions.adapter = es.nodeValue;
newOptions.adapter = es.value;
}

if (es.nodeName === "data-cover-loader") {
newOptions.loader = es.nodeValue;
newOptions.loader = es.value;
}

if (es.nodeName === "data-cover-timeout") {
newOptions.timeout = es.nodeValue;
newOptions.timeout = es.value;
}

if (es.nodeName === "data-cover-modulepattern") {
newOptions.modulePattern = es.nodeValue;
newOptions.modulePattern = es.value;
}

if (es.nodeName === "data-cover-reporter-options") {
try {
newOptions.reporter_options = JSON.parse(es.nodeValue);
newOptions.reporter_options = JSON.parse(es.value);
} catch (e) {
if (blanket.options("debug")) {
throw new Error("Invalid reporter options. Must be a valid stringified JSON object.");
Expand All @@ -5115,15 +5115,15 @@ blanket.defaultReporter = function(coverage) {
}

if (es.nodeName === "data-cover-testreadycallback") {
newOptions.testReadyCallback = es.nodeValue;
newOptions.testReadyCallback = es.value;
}

if (es.nodeName === "data-cover-customvariable") {
newOptions.customVariable = es.nodeValue;
newOptions.customVariable = es.value;
}

if (es.nodeName === "data-cover-flags") {
var flags = " " + es.nodeValue + " ";
var flags = " " + es.value + " ";

if (flags.indexOf(" ignoreError ") > -1) {
newOptions.ignoreScriptError = true;
Expand Down Expand Up @@ -5234,8 +5234,8 @@ blanket.defaultReporter = function(coverage) {
selectedScripts = toArray.call(document.scripts)
.filter(function(s) {
return toArray.call(s.attributes).filter(function(sn) {
return sn.nodeName === "src" && _blanket.utils.matchPatternAttribute(sn.nodeValue, filter) &&
(typeof antimatch === "undefined" || !_blanket.utils.matchPatternAttribute(sn.nodeValue, antimatch));
return sn.nodeName === "src" && _blanket.utils.matchPatternAttribute(sn.value, filter) &&
(typeof antimatch === "undefined" || !_blanket.utils.matchPatternAttribute(sn.value, antimatch));
}).length === 1;
});
} else {
Expand All @@ -5246,7 +5246,7 @@ blanket.defaultReporter = function(coverage) {
return _blanket.utils.qualifyURL(
toArray.call(s.attributes).filter(function(sn) {
return sn.nodeName === "src";
})[0].nodeValue);
})[0].value);
});

if (!filter) {
Expand Down
2 changes: 1 addition & 1 deletion dist/mocha/blanket_mocha.min.js
View file

Large diffs are not rendered by default.

28 changes: 14 additions & 14 deletions dist/qunit/blanket.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5081,36 +5081,36 @@ blanket.defaultReporter = function(coverage) {
toArray.call(scripts[scripts.length - 1].attributes)
.forEach(function(es) {
if (es.nodeName === "data-cover-only") {
newOptions.filter = es.nodeValue;
newOptions.filter = es.value;
}

if (es.nodeName === "data-cover-never") {
newOptions.antifilter = es.nodeValue;
newOptions.antifilter = es.value;
}

if (es.nodeName === "data-cover-reporter") {
newOptions.reporter = es.nodeValue;
newOptions.reporter = es.value;
}

if (es.nodeName === "data-cover-adapter") {
newOptions.adapter = es.nodeValue;
newOptions.adapter = es.value;
}

if (es.nodeName === "data-cover-loader") {
newOptions.loader = es.nodeValue;
newOptions.loader = es.value;
}

if (es.nodeName === "data-cover-timeout") {
newOptions.timeout = es.nodeValue;
newOptions.timeout = es.value;
}

if (es.nodeName === "data-cover-modulepattern") {
newOptions.modulePattern = es.nodeValue;
newOptions.modulePattern = es.value;
}

if (es.nodeName === "data-cover-reporter-options") {
try {
newOptions.reporter_options = JSON.parse(es.nodeValue);
newOptions.reporter_options = JSON.parse(es.value);
} catch (e) {
if (blanket.options("debug")) {
throw new Error("Invalid reporter options. Must be a valid stringified JSON object.");
Expand All @@ -5119,15 +5119,15 @@ blanket.defaultReporter = function(coverage) {
}

if (es.nodeName === "data-cover-testreadycallback") {
newOptions.testReadyCallback = es.nodeValue;
newOptions.testReadyCallback = es.value;
}

if (es.nodeName === "data-cover-customvariable") {
newOptions.customVariable = es.nodeValue;
newOptions.customVariable = es.value;
}

if (es.nodeName === "data-cover-flags") {
var flags = " " + es.nodeValue + " ";
var flags = " " + es.value + " ";

if (flags.indexOf(" ignoreError ") > -1) {
newOptions.ignoreScriptError = true;
Expand Down Expand Up @@ -5238,8 +5238,8 @@ blanket.defaultReporter = function(coverage) {
selectedScripts = toArray.call(document.scripts)
.filter(function(s) {
return toArray.call(s.attributes).filter(function(sn) {
return sn.nodeName === "src" && _blanket.utils.matchPatternAttribute(sn.nodeValue, filter) &&
(typeof antimatch === "undefined" || !_blanket.utils.matchPatternAttribute(sn.nodeValue, antimatch));
return sn.nodeName === "src" && _blanket.utils.matchPatternAttribute(sn.value, filter) &&
(typeof antimatch === "undefined" || !_blanket.utils.matchPatternAttribute(sn.value, antimatch));
}).length === 1;
});
} else {
Expand All @@ -5250,7 +5250,7 @@ blanket.defaultReporter = function(coverage) {
return _blanket.utils.qualifyURL(
toArray.call(s.attributes).filter(function(sn) {
return sn.nodeName === "src";
})[0].nodeValue);
})[0].value);
});

if (!filter) {
Expand Down
2 changes: 1 addition & 1 deletion dist/qunit/blanket.min.js
View file

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions src/blanketRequire.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
selectedScripts = toArray.call(document.scripts)
.filter(function(s) {
return toArray.call(s.attributes).filter(function(sn) {
return sn.nodeName === "src" && _blanket.utils.matchPatternAttribute(sn.nodeValue, filter) &&
(typeof antimatch === "undefined" || !_blanket.utils.matchPatternAttribute(sn.nodeValue, antimatch));
return sn.nodeName === "src" && _blanket.utils.matchPatternAttribute(sn.value, filter) &&
(typeof antimatch === "undefined" || !_blanket.utils.matchPatternAttribute(sn.value, antimatch));
}).length === 1;
});
} else {
Expand All @@ -68,7 +68,7 @@
return _blanket.utils.qualifyURL(
toArray.call(s.attributes).filter(function(sn) {
return sn.nodeName === "src";
})[0].nodeValue);
})[0].value);
});

if (!filter) {
Expand Down
22 changes: 11 additions & 11 deletions src/config.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,36 +7,36 @@
toArray.call(scripts[scripts.length - 1].attributes)
.forEach(function(es) {
if (es.nodeName === "data-cover-only") {
newOptions.filter = es.nodeValue;
newOptions.filter = es.value;
}

if (es.nodeName === "data-cover-never") {
newOptions.antifilter = es.nodeValue;
newOptions.antifilter = es.value;
}

if (es.nodeName === "data-cover-reporter") {
newOptions.reporter = es.nodeValue;
newOptions.reporter = es.value;
}

if (es.nodeName === "data-cover-adapter") {
newOptions.adapter = es.nodeValue;
newOptions.adapter = es.value;
}

if (es.nodeName === "data-cover-loader") {
newOptions.loader = es.nodeValue;
newOptions.loader = es.value;
}

if (es.nodeName === "data-cover-timeout") {
newOptions.timeout = es.nodeValue;
newOptions.timeout = es.value;
}

if (es.nodeName === "data-cover-modulepattern") {
newOptions.modulePattern = es.nodeValue;
newOptions.modulePattern = es.value;
}

if (es.nodeName === "data-cover-reporter-options") {
try {
newOptions.reporter_options = JSON.parse(es.nodeValue);
newOptions.reporter_options = JSON.parse(es.value);
} catch (e) {
if (blanket.options("debug")) {
throw new Error("Invalid reporter options. Must be a valid stringified JSON object.");
Expand All @@ -45,15 +45,15 @@
}

if (es.nodeName === "data-cover-testreadycallback") {
newOptions.testReadyCallback = es.nodeValue;
newOptions.testReadyCallback = es.value;
}

if (es.nodeName === "data-cover-customvariable") {
newOptions.customVariable = es.nodeValue;
newOptions.customVariable = es.value;
}

if (es.nodeName === "data-cover-flags") {
var flags = " " + es.nodeValue + " ";
var flags = " " + es.value + " ";

if (flags.indexOf(" ignoreError ") > -1) {
newOptions.ignoreScriptError = true;
Expand Down

0 comments on commit d647f2b

Please sign in to comment.