Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the test suite #153

Open
aleclarson opened this issue Aug 11, 2024 · 1 comment
Open

Improvements to the test suite #153

aleclarson opened this issue Aug 11, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@aleclarson
Copy link
Owner

aleclarson commented Aug 11, 2024

The old test suite broke a while back when we migrated from tsconfig-paths to tsconfck. It used Jest. I just removed that test suite, since it wasn't doing us any good. I also didn't like its approach, which involved a lot of module mocking.

If someone wants to contribute a new test suite, here are the guidelines:
1. Use Vitest
2. Focus on E2E integration tests. To accomplish this, you could add a spec/__fixtures__ folder with various subfolders (one per test case, to keep things separated).
3. Try covering all test cases that were previously covered (see here). If you don't have the bandwidth, that's fine. Maybe someone else can help out. Even if you can only provide the most basic integration test, it would be appreciated.
4. Restore the test script in package.json
5. Re-enable the GitHub workflow (see here). You can keep the Codecov upload (its secret is still intact).

@aleclarson aleclarson added the help wanted Extra attention is needed label Aug 11, 2024
@aleclarson aleclarson pinned this issue Aug 11, 2024
@aleclarson
Copy link
Owner Author

Vitest has been set up in 1cfbe4d.

  • Re-enable the GitHub workflow
  • Add more test cases

@aleclarson aleclarson changed the title This plugin needs a test suite 👀 Improvements to the test suite Nov 10, 2024
@aleclarson aleclarson unpinned this issue Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant