feat(rpc): add rundler_getMinedUserOperation #1045
Open
+302
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
requested review from
dphilipson,
0xfourzerofour,
alex-miao and
andysim3d
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dancoombs
force-pushed
the
danc/rundler-receipt
branch
6 times, most recently
from
73d64b9 to
147982e
Compare
dancoombs
force-pushed
the
danc/rundler-receipt
branch
from
147982e to
cc2d109
Compare
| (Some(uo), Some(mut receipt)) => { | ||
| // clear out the outer transaction logs from the receipt to avoid sending | ||
| // extra data in the response. OOF - this type is a mess. | ||
| receipt.receipt.inner.inner.receipt.logs.clear(); |
| @@ -91,24 +104,40 @@ where | |||
| ) | |||
| .await | |||
| } | |||
|
|
|||
| async fn get_mined_user_operation( | |||
There was a problem hiding this comment.
do we want to add tracing to this request?
| tx_receipt: &'a TransactionReceipt, | ||
| ) -> Option<&'a Log> { | ||
| tx_receipt.inner.logs().iter().find(|l| { | ||
| l.topics()[0] == E::UserOperationEvent::SIGNATURE_HASH && l.topics()[1] == uo_hash |
There was a problem hiding this comment.
if passed an incorrect tx receipt will this return an index out of bounds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1044
Proposed Changes
rundler_getMinedUserOperation