Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnValueProvider should support dealing with empty tables #88

Closed
cptanalatriste opened this issue May 10, 2023 · 0 comments · Fixed by #89
Closed

ColumnValueProvider should support dealing with empty tables #88

cptanalatriste opened this issue May 10, 2023 · 0 comments · Fixed by #89
Assignees

Comments

@cptanalatriste
Copy link
Collaborator

cptanalatriste commented May 10, 2023

Today, @cptanalatriste and I made changes / additions until we were able to successfully run `make-tables`, `make-generators`, `create-tables`, `create-generators` and `create-data` on the `cms_desynpuf_sample_53_large` schema:

- *could be in a separate PR* truncated String col types to account for a couple of `VARCHAR(1)`s
- made a custom config and generators file to account for the combined pk & fk of death.person_id
- *could be in a separate PR* returned None (IE no rows) from ColumnValueProvider rather than erroring if there are no rows in the table using `getattr(...,None)`

Originally posted by @Iain-S in #59 (comment)

This issue deals with the third item. We need ColumnValueProvider to return None when the target column is not populated, instead of crashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant