Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead link in 4.0.1 #197

Closed
oC-n opened this issue Feb 10, 2023 · 4 comments · Fixed by #199
Closed

Dead link in 4.0.1 #197

oC-n opened this issue Feb 10, 2023 · 4 comments · Fixed by #199

Comments

@oC-n
Copy link
Contributor

oC-n commented Feb 10, 2023

Under the Markdown heading, there is a link to a file that doesn't currently exist, showing the notebook in HTML form: [web](https://github.com/alan-turing-institute/rse-course/blob/main/module04_version_control_with_git/04_00_introduction.html)

@jemrobinson
Copy link
Member

Do you want to make a PR to fix this @oC-n ? Should be a nice quick one :)

@oC-n
Copy link
Contributor Author

oC-n commented Feb 13, 2023

Can do, @jemrobinson . Was just waiting until I'm sure I've got the procedure right. I'll link to https://github.com/alan-turing-institute/rse-course/blob/gh-pages/html/module04_version_control_with_git/04_00_introduction.html

@jemrobinson
Copy link
Member

jemrobinson commented Feb 13, 2023

It might be better to link to https://alan-turing-institute.github.io/rse-course/html/module04_version_control_with_git/04_00_introduction.html which shows the processed HTML.

@oC-n
Copy link
Contributor Author

oC-n commented Feb 13, 2023

Pull request created: #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants