Updates to module 03 #146
Merged
Updates to module 03 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jemrobinson
force-pushed
the
module03-updates
branch
from
8d8578b to
0d2c555
Compare
jemrobinson
requested review from
craddm,
edwardchalstrey1,
lukehare and
radka-j
radka-j
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Looks good! I just spotted one typo (see comment). One minor suggestion is to include a definition of dot product at the top of 3.5.5. Personally, I'd call it matrix multiplication because I think that's a more familiar term and I'd also be very explicit that we want a row by column operation.
Co-authored-by: Radka Jersakova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145