Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup pin code leads to incorrect code generation #122

Closed
zverev-iv opened this issue Apr 7, 2023 · 8 comments
Closed

setup pin code leads to incorrect code generation #122

zverev-iv opened this issue Apr 7, 2023 · 8 comments
Assignees
Labels
question Further information is requested

Comments

@zverev-iv
Copy link

zverev-iv commented Apr 7, 2023

Case: I Have QR code with all info.

  1. I added this TOTP in two apps (andOTP android, but I think you can use anything else) and in flipper TOTP.
  2. They show the same code. Codes works.
  3. Then I set up pin code on flipper totp (using telnet) and close the app
  4. After flipper TOTP restart it shows different codes from andOTP and this code isn't usable

Firmware unlshd-042e

@akopachov akopachov self-assigned this Apr 7, 2023
@akopachov
Copy link
Owner

Could you please provide Authenticator version and your Flipper's firmware and its version?

@zverev-iv
Copy link
Author

@akopachov
Copy link
Owner

Here is what I did to test this on my Flipper:

  1. Grab new secret here
  2. Added it to the app
  3. Made sure generated code is correct
  4. Removed PIN via totp pin remove
  5. Made sure generated code is correct
  6. Restarted app
  7. Made sure generated code is correct
  8. Setup new PIN via totp pin set
  9. Made sure generated code is correct
  10. Restarted app
  11. Made sure generated code is correct

So far was not able to reproduce the issue.

Do you remember if any unusual things happened? Or maybe something what is not covered by the test steps I did above? Can you try to reproduce this issue using test website I provided above?

@akopachov
Copy link
Owner

In any case, logged #123 to make sure there is backup

@akopachov akopachov added the question Further information is requested label Apr 7, 2023
@akopachov
Copy link
Owner

Do you remember if any unusual things happened? Or maybe something what is not covered by the test steps I did above? Can you try to reproduce this issue using test website I provided above?

Is there any chance to try it?

@akopachov
Copy link
Owner

Closing as I was not able to reproduce this issue, author is not responding and the necessary improvements to take a backup before setting\removing PIN is added.

@zverev-iv
Copy link
Author

Hi! Sorry for late answer.
I can't reproduce it.
I tried many times. actually happened twice, but perhaps this is due to the time shift in rtc (for example, it leads to a firmware update or something else)

@akopachov
Copy link
Owner

It could be because of clock drift, if you didn't connect your flipper device to qFlipper for a long.

Also it may occur if user or firmware changed device ID somehow (it should never happens in normal cases, but still it is possible and there was at least on report where user faced such an issue on custom RM firmware).

In any case, thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants