Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks on inline base64 images in styles #32

Closed
aleemb opened this issue Jun 13, 2017 · 2 comments
Closed

Breaks on inline base64 images in styles #32

aleemb opened this issue Jun 13, 2017 · 2 comments

Comments

@aleemb
Copy link

aleemb commented Jun 13, 2017 •
edited
Loading

Issue #28 fixes : bug due to the background-image property containing a : as per

background-image:url(http://foo.com)

In a similar class of bugs is an inline style containing a ;

background-image:url(data:image/png;base64,iVBORw0KGgoAAA)

Since styles are split on ; this breaks.
@aknuds1
Copy link
Owner

aknuds1 commented Jun 13, 2017

Would you mind submitting a PR please with a test corresponding to the bug?

@aleemb aleemb mentioned this issue Jun 13, 2017
Merged
@aleemb
Copy link
Author

aleemb commented Jun 13, 2017

@aknuds1 submitted PR. Unit tests passing and tested within my app, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleemb @aknuds1