Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly sign executables for MacOS #9

Merged
merged 5 commits into from
Sep 21, 2024
Merged

Conversation

aklinker1
Copy link
Owner

After testing, it seems like we need to sign and notarize, but not staple. Tried stapling, got a weird error:

Downloaded ticket has been stored at file:///var/folders/0g/.../T/....ticket.
Could not remove existing ticket from bun/Contents/CodeResources -- file:///Users/runner/work/bunv/bunv/zig-out/bin/ because an error occurred. Error Domain=NSCocoaErrorDomain Code=512 "“CodeResources” couldn’t be removed." UserInfo={NSUserStringVariant=(
    Remove
), NSFilePath=/Users/runner/work/bunv/bunv/zig-out/bin/bun/Contents/CodeResources, NSUnderlyingError=0x6000015388d0 {Error Domain=NSPOSIXErrorDomain Code=20 "Not a directory"}}
The staple and validate action failed! Error 73.

Seemed like stapling doesn't seem to work on binarys, only .pkg files. Gatekeeper doesn't seem to fire if the binaries are signed an notarized, so that's what I'm doing.

@aklinker1 aklinker1 merged commit e348ee2 into main Sep 21, 2024
@aklinker1 aklinker1 deleted the signing-issues branch September 21, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant