Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with dask arrays #107

Closed
rabernat opened this issue Mar 19, 2019 · 5 comments
Closed

Work with dask arrays #107

rabernat opened this issue Mar 19, 2019 · 5 comments

Comments

@rabernat
Copy link
Contributor

Thanks for providing this amazing package. It is absolutely one of the best and most useful python packages I know of!

Currently eofs only works with numpy arrays. However, its core computational algorithm, svd, is implemented in dask array. http://dask.pydata.org/en/latest/array-api.html

This means that it would theoretically be possible for eofs to leverage dask to do out of core EOFs with minimal refactoring.

Is this on your roadmap? Would be keen to help if you’re interested.

@rabernat
Copy link
Contributor Author

Some inspiration for why this could be cool:

https://www.youtube.com/watch?v=R5CiXti_MWo

@rabernat
Copy link
Contributor Author

Hi @ajdawson - any thoughts on this query?

@ajdawson
Copy link
Owner

This is a good suggestion @rabernat. I have no roadmap for this software, and little time to work on it. That said, I'm happy to support an effort on this front though.

I'm imagining the eofs.standard interface would be extended to support dask as well as numpy in a transparent way, that way the metadata interfaces built on top can make use of either. Is that what you had in mind in terms of basic design? I haven't really done my homework on this though!

@navidcy
Copy link

navidcy commented Mar 27, 2019

@rabernat I salute this suggestion. I read in the documentation the

The xarray interface works with DataArray objects, which are the data containers used by the xarray package.

and I wrongly assumed that this also implied support of dask. Then I spend an hour trying to make things work with xarray+dask before I noticed this issue :)

@ajdawson
Copy link
Owner

ajdawson commented May 2, 2019

Done in #109

@ajdawson ajdawson closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants