Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting the placeholder type for nls #5584

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

akoreman
Copy link
Contributor

@akoreman akoreman commented Jun 8, 2024

Issue #, if available: NA

Description of changes: Follow-up to #5581, when setting the translated messages, allow configuring which placeholder is used for parameters. The allowed options are dollar signs or curly brackets. Default to dollar signs to not break current behavior.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (6e217a7) to head (93ac44c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5584   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files         594      594           
  Lines       43020    43033   +13     
  Branches     7129     7132    +3     
=======================================
+ Hits        37334    37347   +13     
  Misses       5686     5686           
Flag Coverage Δ
unittests 86.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@InspiredGuy InspiredGuy merged commit 3e2d50f into ajaxorg:master Jun 11, 2024
3 checks passed
@akoreman akoreman deleted the nls_options branch December 6, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants