-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make translation system key based and add annotation type to gutter icon aria labels #5524
feat: Make translation system key based and add annotation type to gutter icon aria labels #5524
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5524 +/- ##
=======================================
Coverage 86.60% 86.61%
=======================================
Files 590 591 +1
Lines 42705 42732 +27
Branches 7096 7102 +6
=======================================
+ Hits 36985 37012 +27
Misses 5720 5720
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nls(key, defaultString, params) { | ||
if (!messages[key]) { | ||
warn("No message found for the key '" + key + "' in the provided messages, trying to find a translation for the default string '" + defaultString + "'."); | ||
if (!messages[defaultString]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we keeping this default string logic for backwards compatibility reasons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I kept this so that Ace users who currently have translations set-up don't get those broken by this change (well that's the goal at least 😄)
Issue #, if available: #5499
Description of changes: Changing the API we have for UI string translations from being based on the default value of the string to a more abstract key. Aim was to do this in a way that doesn't break users who currently use translations for the default value of the strings.
Changes:
nls
step in the build accordinglyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: