feat: Keep focus on same item in completion popup when slow completer delivers results. #5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5322 +/- ##
==========================================
+ Coverage 87.38% 87.39% +0.01%
==========================================
Files 574 574
Lines 45534 45594 +60
Branches 6935 6938 +3
==========================================
+ Hits 39788 39848 +60
Misses 5746 5746
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
marinsokol5
reviewed
Sep 22, 2023
| @@ -62,6 +62,7 @@ class Autocomplete { | |||
| this.keyboardHandler.bindKeys(this.commands); | |||
| this.parentNode = null; | |||
| this.setSelectOnHover = false; | |||
| this.stickySelectionDelay = 500; | |||
There was a problem hiding this comment.
Can we add JSDoc comment somehow. for this option, since it's a bit hard to understand from just the name without prior context, but it's a pretty cool functionality.
There was a problem hiding this comment.
added a (hopefully) descriptive comment about this feature
marinsokol5
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: NA
Description of changes: Currently, when there are new async completion results delivered by a completer, the active row of the popup is set back to 0. This is jarring when there are completers which are sufficiently slow that the user has already started to interact with the other, faster, completion results.
This adds a timer such that when completions are delivered a configurable number of milliseconds after opening the popup, the item in focus remains in focus after the new results are added to the popup.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.