Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow button does not show for long lines without spaces #4817

Closed
Exaphis opened this issue Jun 2, 2022 · 1 comment
Closed

Overflow button does not show for long lines without spaces #4817

Exaphis opened this issue Jun 2, 2022 · 1 comment

Comments

@Exaphis
Copy link
Contributor

Exaphis commented Jun 2, 2022

Describe the bug

When a line has over 10000 characters and has no spaces, the click to see more button does not appear. Users cannot scroll to the end of the line.

Expected Behavior

The click to see more button should appear.

Current Behavior

The click to see more button does not appear.

Reproduction Steps

Enter a line with 10050 consecutive a's. The end of the line is cut off.
Add a space into the line. The click to see more button appears.

Possible Solution

In lib/ace/layer/text.js, the screenColumn + value.length > this.MAX_LINE_LENGTH check should occur for every token, not just the first. I will submit a PR for this.

Additional Information/Context

No response

Ace Version

1.5.3

@Exaphis Exaphis changed the title (module name): (short issue description) Overflow button does not show for long lines without spaces Jun 2, 2022
@andrewnester
Copy link
Contributor

Released in 1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants