Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax error in php-mode #4731

Closed
gentlawk opened this issue May 10, 2022 · 2 comments
Closed

syntax error in php-mode #4731

gentlawk opened this issue May 10, 2022 · 2 comments

Comments

@gentlawk
Copy link

gentlawk commented May 10, 2022

Hello team,

In ace1.4.14 php-mode, ace editor showed syntax error at property with 'readonly' and type declaration.
I think it allows to use 'readonly' and type declaration at the same time in PHP8.1.

<?php

class A
{
    public int $a; // => OK
    public readonly $b; // => OK
    public readonly int $c; // => Syntax Error :( 
}

Could you fix this?

Best regards.

@andrewnester andrewnester transferred this issue from ajaxorg/ace-builds May 30, 2022
@andrewnester
Copy link
Contributor

Been fixed here #4696 and release in 1.5+ versions

@gentlawk
Copy link
Author

I can see the problem was fixed at ver1.5.2!!
Thank you very much for your reaction and fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants