Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyYAML to dependencies in pyproject.toml #601

Closed
rjambrecic opened this issue Sep 12, 2023 · 3 comments · Fixed by #603
Closed

Add PyYAML to dependencies in pyproject.toml #601

rjambrecic opened this issue Sep 12, 2023 · 3 comments · Fixed by #603
Assignees
Labels
bug Something isn't working

Comments

@rjambrecic
Copy link
Contributor

rjambrecic commented Sep 12, 2023

When you install:
pip install faststream[kafka]

and run:
faststream run application:app

you get:
ModuleNotFoundError: No module named 'yaml'

@Lancetnik
Copy link
Member

We need no to add yaml to project dependencies: this is optional
I will review all imports to build project correct without it

@Lancetnik Lancetnik assigned Lancetnik and unassigned sternakt Sep 12, 2023
@Lancetnik Lancetnik added the bug Something isn't working label Sep 12, 2023
@rjambrecic
Copy link
Contributor Author

  File "/home/robert/fast-crypto/venv-crypto/lib/python3.8/site-packages/faststream/cli/docs/app.py", line 7, in <module>
    import yaml
ModuleNotFoundError: No module named 'yaml'

CLI import yaml. which is not found.

@Lancetnik
Copy link
Member

Lancetnik commented Sep 12, 2023

I know, usage direct yaml is a mistake

@Lancetnik Lancetnik moved this to In Progress in FastStream Sep 12, 2023
@Lancetnik Lancetnik linked a pull request Sep 12, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in FastStream Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants