Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reentrancy problems with testing #556

Closed
sternakt opened this issue Sep 6, 2023 · 3 comments
Closed

Fix reentrancy problems with testing #556

sternakt opened this issue Sep 6, 2023 · 3 comments
Assignees
@sternakt
Labels
bug Something isn't working

Comments

@sternakt
Copy link
Collaborator

sternakt commented Sep 6, 2023 •
edited
Loading

Skipped tests for reentrancy are at tests/brokers/kafka/test_test_reentrancy.py
Should be enabled and passing when reentrancy problems are resolved
@sternakt sternakt self-assigned this Sep 6, 2023
sternakt referenced this issue Sep 6, 2023
@sternakt @davorrunje
499 create a publishers subcribers in the testbroker wrapper with wit…
cebace8 
…h real flag (#529)

* Replace Tester functions with tester context managers

* Ignore Test classes in pytest collection

* Fix typing

* Add broker.start() to Testing context manager

* Add example for testing with real broker

* Patch publishers so they can be checked if they were called

* polish docs

* polish docs

* Skip reentrancy tests

---------

Co-authored-by: Davor Runje <[email protected]>
@davorrunje davorrunje linked a pull request Sep 7, 2023 that will close this issue
499 create a publishers subcribers in the testbroker wrapper with with real flag #529
Merged
@davorrunje davorrunje removed a link to a pull request Sep 7, 2023
499 create a publishers subcribers in the testbroker wrapper with with real flag #529
Merged
@Lancetnik Lancetnik mentioned this issue Sep 7, 2023
Merged
@Lancetnik Lancetnik added the bug Something isn't working label Sep 7, 2023
@Lancetnik
Copy link
Member

We need to correct behavior attempt subscriber case: subscribers, created inside test function are not removing from global broker object and failure other tests

@Lancetnik Lancetnik moved this to Todo in FastStream Sep 7, 2023
@sternakt sternakt moved this from Todo to Backlog in FastStream Sep 11, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in FastStream Sep 25, 2023
@Lancetnik
Copy link
Member

We still have a tests failing this case: https://github.com/airtai/faststream/blob/main/tests/brokers/kafka/test_test_reentrancy.py#L61 and
https://github.com/airtai/faststream/blob/main/tests/brokers/rabbit/test_test_reentrancy.py#L62
So, we need to remove or support them

@Lancetnik Lancetnik reopened this Sep 25, 2023
@Lancetnik Lancetnik moved this from Done to Todo in FastStream Sep 25, 2023
@davorrunje davorrunje moved this from Todo to Backlog in FastStream Oct 9, 2023
@Lancetnik
Copy link
Member

Copy of #1036

@github-project-automation github-project-automation bot moved this from Backlog to Done in FastStream Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sternakt sternakt

Labels
bug Something isn't working
Projects
FastStream
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davorrunje @Lancetnik @sternakt