Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add K8S probes checker API #1181

Closed
1 of 4 tasks
Lancetnik opened this issue Jan 29, 2024 · 3 comments · Fixed by #1635
Closed
1 of 4 tasks

Feature: add K8S probes checker API #1181

Lancetnik opened this issue Jan 29, 2024 · 3 comments · Fixed by #1635
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Lancetnik
Copy link
Member

Lancetnik commented Jan 29, 2024

We should provides users with an ability to check application health in a some way. It can be reached by using multiple mechanism, so we can create a base Checker Protocol and use it the following way

app = FastStream(broker)
app.add_checker(
     SocketChecker("/sock"),
     # HTTPChecker(port=8000),
     # ...
)

And check all of them by the same command

faststream probe main:app

So, we can create multiple checkers for various cases and user can implement any checker by itself in the same time

  • add broker.ping() unified method
  • add BaseCheker using broker.ping()
  • implement HTTPChecker (inheritor of BaseCheker)
  • add CLI command to use any checker
@Lancetnik Lancetnik added the enhancement New feature or request label Jan 29, 2024
@Lancetnik Lancetnik moved this to Backlog in FastStream Jan 29, 2024
@Lancetnik Lancetnik added the good first issue Good for newcomers label Jan 29, 2024
@Lancetnik
Copy link
Member Author

Lancetnik commented Mar 9, 2024

Assigned to @Sehat1137

@danb27
Copy link

danb27 commented Apr 2, 2024

I would love this feature! +1

@Lancetnik
Copy link
Member Author

reassigned to @chudomozg

@Lancetnik Lancetnik mentioned this issue Aug 3, 2024
13 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in FastStream Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants