Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock installed package version #133

Open
mwelk opened this issue Apr 10, 2022 · 5 comments
Open

Lock installed package version #133

mwelk opened this issue Apr 10, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@mwelk
Copy link

mwelk commented Apr 10, 2022

With version 1.1.5 of apm a package gets updated even if it is compatible with a dependency of a new installed package,

It would be great if a package version can be locked and unlocked so that it will not get re-installed with a new version if it is still compatible,

@marchbold
Copy link
Contributor

Can you give me an example of what you mean?

@mwelk
Copy link
Author

mwelk commented Apr 11, 2022

com.distriqt.Application:6.8.2 has following dependencies:

"dependencies": [
    "com.distriqt.Core:6.4.3",
    "androidx.core:1.3.2"
  ],

but installing com.distriqt.Share:7.1.1 also updates the androidx.core to version 1.6.1 even the Share dependencies are compatible with version 1.3.2 of androidx.core:

  "dependencies": [
    "com.distriqt.Core:6.x.x",
    "androidx.core:1.x.x"
  ],

I'm currently investigating an issue with androidx.core:1.6.1 and would therefore keep the version 1.3.2 for my app.

@marchbold
Copy link
Contributor

The latest Share ANE is not compatible with androidx.core 1.3.2. 7.1.1 was incorrectly specifying 1.x.x but has been corrected in 7.1.2.

However I would expect it to install 1.3.2 in the above case as it's specifically mentioned in the dependencies list. I'll check into what's happening there. There may be some case I'm not recalling.

Also I believe you should be able to install the androidx.core package directly and that may "lock" the version for you. i.e. apm install androidx.core 1.3.2

@mwelk
Copy link
Author

mwelk commented Apr 12, 2022

I already tried to 'lock' androidx.core by installing version 1.3.2 manually, but nevertheless it gets updated by installing the com.distriqt.Share:7.1.1

@marchbold
Copy link
Contributor

Okay, will look into adding a feature around this. But currently I don't recommend attempting to use Share v7.1.1 with the old androidx libs. It requires a newer version.

@marchbold marchbold added the enhancement New feature or request label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants