(WIP) Fix masks for instance segmentation #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 31, 2021 22:59
… a 2d array is given. Also made sure that if the mask_array for a record is None but the record has a mask the mask array is loaded in the draw function instead of trying to plot the None value. With this changes the usage of the COCOMetric no longer thorws an error but the value is 0.
Codecov Report
@@ Coverage Diff @@
## master #967 +/- ##
==========================================
- Coverage 85.71% 85.38% -0.33%
==========================================
Files 254 254
Lines 5515 5570 +55
==========================================
+ Hits 4727 4756 +29
- Misses 788 814 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 2 commits
November 11, 2021 21:14
…problem was, that the records used for the ground truth did not contain the masks and boxes after the transformations but the ones before. This is now changed in the valid step of the model adapters. Furthermore, I found a bug in the set_masks function for the BaseMasksRecordComponent were the clear functions was not called (the brackets were missing).
…nd only updates the records in that case.
|
This should complete the PR and it should be ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: