Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) init coco and via parser with a dict instead of the filepath #963

Merged

Conversation

fstroth
Copy link
Contributor

@fstroth fstroth commented Oct 31, 2021

With this PR the filepath argument for the coco and via parser can be a dict. This is usefull if the annotations are not loaded from disk but from an api.
The name of the init parametr filepath was not changed to not break the api.

…stead of the filepath. The name of the init paramter filepath was not changed to not break the api.
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #963 (0ad8724) into master (f6d137d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   85.65%   85.71%   +0.05%     
==========================================
  Files         254      254              
  Lines        5506     5515       +9     
==========================================
+ Hits         4716     4727      +11     
+ Misses        790      788       -2     
Flag Coverage Δ
unittests 85.71% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icevision/parsers/coco_parser.py 100.00% <100.00%> (ø)
icevision/parsers/via_parser.py 100.00% <100.00%> (ø)
...ision/engines/lightning/lightning_model_adapter.py 100.00% <0.00%> (ø)
icevision/__init__.py 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b305489...0ad8724. Read the comment docs.

@ai-fast-track
Copy link
Collaborator

With this PR the filepath argument for the coco and via parser can be a dict. This is usefull if the annotations are not loaded from disk but from an api. The name of the init parametr filepath was not changed to not break the api.

Thanks for the PR @fstroth. Is this use-case found in the IceVision Dashboard?

@ai-fast-track ai-fast-track merged commit 0d441fa into airctic:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants