Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Update) Updated code to run with albumentations version 1.0.3. #927

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

fstroth
Copy link
Contributor

@fstroth fstroth commented Sep 20, 2021

Only a change of the test was required.

setup.cfg Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #927 (8c55725) into master (f0d1fe0) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   85.85%   85.77%   -0.08%     
==========================================
  Files         251      251              
  Lines        5471     5443      -28     
==========================================
- Hits         4697     4669      -28     
  Misses        774      774              
Flag Coverage Δ
unittests 85.77% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icevision/core/bbox.py 75.00% <0.00%> (-2.66%) ⬇️
icevision/utils/code_template.py 58.82% <0.00%> (-2.29%) ⬇️
icevision/core/class_map.py 74.46% <0.00%> (-0.54%) ⬇️
icevision/utils/utils.py 75.92% <0.00%> (-0.44%) ⬇️
icevision/parsers/parser.py 70.83% <0.00%> (-0.40%) ⬇️
icevision/core/keypoints.py 93.10% <0.00%> (-0.23%) ⬇️
icevision/core/mask.py 82.51% <0.00%> (-0.13%) ⬇️
...sion/tfms/albumentations/albumentations_adapter.py 96.04% <0.00%> (-0.11%) ⬇️
icevision/models/mmdet/lightning/model_adapter.py 96.87% <0.00%> (-0.10%) ⬇️
icevision/core/record_components.py 81.52% <0.00%> (-0.06%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d1fe0...8c55725. Read the comment docs.

@lgvaz
Copy link
Collaborator

lgvaz commented Sep 23, 2021

Alriight, seems good, that little test failing is not related to this

Thank you!

@lgvaz lgvaz merged commit 3a426a3 into airctic:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants