Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing fiftyone as a hard dependency #1055

Merged
merged 5 commits into from
Feb 2, 2022

Conversation

FraPochetti
Copy link
Contributor

@FraPochetti FraPochetti commented Feb 1, 2022

  • Removed fiftyone as a hard dependency. Needs to be installed separately now.
  • Added disclaimer to fiftyone notebook about Colab incompatibility.
  • Made sure every notebook installs from pypi and not from master.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #1055 (f0f9a60) into master (411101d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1055   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files         283      283           
  Lines        5941     5943    +2     
=======================================
+ Hits         5107     5109    +2     
  Misses        834      834           
Flag Coverage Δ
unittests 85.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icevision/data/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411101d...f0f9a60. Read the comment docs.

@ai-fast-track
Copy link
Collaborator

Thanks a lot, @FraPochetti!

@fstroth fstroth merged commit 9c17564 into airctic:master Feb 2, 2022
@FraPochetti FraPochetti deleted the fiftyone_fix branch February 2, 2022 15:44
@Zubair2019
Copy link

Zubair2019 commented Feb 2, 2022

  • Removed fiftyone as a hard dependency. Needs to be installed separately now.
  • Added disclaimer to fiftyone notebook about Colab incompatibility.
  • Made sure every notebook installs from pypi and not from master.

Have you checked which models are added when installing via PyPi? Last time I checked there were just a few models in the mmdet directory. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants