Add YOLOF mmdet model #1030
Merged
Add YOLOF mmdet model #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #1030 +/- ##
==========================================
+ Coverage 85.71% 85.80% +0.09%
==========================================
Files 258 261 +3
Lines 5679 5694 +15
==========================================
+ Hits 4868 4886 +18
+ Misses 811 808 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks for your contribution @dnth ! |
|
I am so happy as this is my first contribution to IceVision! Thank you for the guides and documentations! |
FraPochetti
reviewed
Jan 18, 2022
| @@ -47,7 +47,7 @@ def param_groups(model): | |||
| layers += [getattr(body, l) for l in body.res_layers] | |||
|
|
|||
| # add the neck module if it exists (DETR doesn't have a neck module) | |||
| layers += [model.neck for name in model.named_modules() if name == "neck"] | |||
| layers += [module for name, module in model.named_modules() if name == "neck"] | |||
There was a problem hiding this comment.
This change was merged in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the YOLOF model from mmdet to IceVision