Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fixed the bug to add neck modules properly #1029

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

hectorLop
Copy link
Contributor

Fix a bug introduced by the DETR implementation. The problem was that when iterating the named_modules(), it return both the name and the module, but it was iterated as it was a list so the statement if name == 'neck' was never going to be True.

@hectorLop
Copy link
Contributor Author

Here is a colab notebook, similar to the getting started, but I added a section where I create the YOLOx, Retinanet and DETR models and use fastai to find their optimar learning rates. Thus, it shows that now they can be created succesfully.

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1029 (43edced) into master (75aac22) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   85.76%   85.71%   -0.05%     
==========================================
  Files         258      258              
  Lines        5676     5679       +3     
==========================================
  Hits         4868     4868              
- Misses        808      811       +3     
Flag Coverage Δ
unittests 85.71% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icevision/models/mmdet/utils.py 63.15% <0.00%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75aac22...43edced. Read the comment docs.

@FraPochetti FraPochetti merged commit 21e74aa into airctic:master Jan 18, 2022
@FraPochetti
Copy link
Contributor

Thanks a ton again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants