From 3dc08c72cbd5f2bca819029b92ac5b1a5635f085 Mon Sep 17 00:00:00 2001 From: Benoit Moriceau Date: Tue, 15 Nov 2022 14:06:59 -0800 Subject: [PATCH 1/2] remove sleep and repeat test to check non flakyness --- .../io/airbyte/test/acceptance/BasicAcceptanceTests.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/BasicAcceptanceTests.java b/airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/BasicAcceptanceTests.java index 4f9baa0bc91b6..77f74704d5b08 100644 --- a/airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/BasicAcceptanceTests.java +++ b/airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/BasicAcceptanceTests.java @@ -106,6 +106,7 @@ import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Order; +import org.junit.jupiter.api.RepeatedTest; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.TestInfo; import org.junit.jupiter.api.condition.DisabledIfEnvironmentVariable; @@ -660,6 +661,7 @@ void testIncrementalSync() throws Exception { @Test @Order(14) + @RepeatedTest(100) void testDeleteConnection() throws Exception { final UUID sourceId = testHarness.createPostgresSource().getSourceId(); final UUID destinationId = testHarness.createPostgresDestination().getDestinationId(); @@ -688,9 +690,6 @@ void testDeleteConnection() throws Exception { // connectionIds.remove(connectionId); // todo remove testHarness.removeConnection(connectionId); - LOGGER.info("Waiting for connection to be deleted..."); - Thread.sleep(5000); - ConnectionStatus connectionStatus = apiClient.getConnectionApi().getConnection(new ConnectionIdRequestBody().connectionId(connectionId)).getStatus(); assertEquals(ConnectionStatus.DEPRECATED, connectionStatus); @@ -710,9 +709,6 @@ void testDeleteConnection() throws Exception { // we should still be able to delete the connection when the temporal workflow is in this state apiClient.getConnectionApi().deleteConnection(new ConnectionIdRequestBody().connectionId(connectionId)); - LOGGER.info("Waiting for connection to be deleted..."); - Thread.sleep(5000); - connectionStatus = apiClient.getConnectionApi().getConnection(new ConnectionIdRequestBody().connectionId(connectionId)).getStatus(); assertEquals(ConnectionStatus.DEPRECATED, connectionStatus); } From e97cdc9b474d7177a06d4bd8356a93ec4c25190a Mon Sep 17 00:00:00 2001 From: Benoit Moriceau Date: Tue, 15 Nov 2022 15:10:22 -0800 Subject: [PATCH 2/2] Remove repeated test --- .../java/io/airbyte/test/acceptance/BasicAcceptanceTests.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/BasicAcceptanceTests.java b/airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/BasicAcceptanceTests.java index 77f74704d5b08..e87404887e5e0 100644 --- a/airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/BasicAcceptanceTests.java +++ b/airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/BasicAcceptanceTests.java @@ -106,7 +106,6 @@ import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Order; -import org.junit.jupiter.api.RepeatedTest; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.TestInfo; import org.junit.jupiter.api.condition.DisabledIfEnvironmentVariable; @@ -661,7 +660,6 @@ void testIncrementalSync() throws Exception { @Test @Order(14) - @RepeatedTest(100) void testDeleteConnection() throws Exception { final UUID sourceId = testHarness.createPostgresSource().getSourceId(); final UUID destinationId = testHarness.createPostgresDestination().getDestinationId();