Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease code paths where secrets can be accessed #9947

Closed
Tracked by #9646
cgardens opened this issue Feb 1, 2022 · 2 comments
Closed
Tracked by #9646

Decrease code paths where secrets can be accessed #9947

cgardens opened this issue Feb 1, 2022 · 2 comments
Assignees
Labels
area/platform issues related to the platform team/compose team/platform-move type/enhancement New feature or request

Comments

@cgardens
Copy link
Contributor

cgardens commented Feb 1, 2022

Tell us about the problem you're trying to solve

Currently secrets are written and read using ConfigRespository. This makes it heard to easily tell where secrets can be access because this class is used frequently throughout the codebase. We should refactor ConfigRepository to not include secrets handling so it is easier to track where secrets might be accessed.

PR to address it here.

@cgardens cgardens added type/enhancement New feature or request area/platform issues related to the platform labels Feb 1, 2022
@jrhizor
Copy link
Contributor

jrhizor commented Feb 2, 2022

One other part that makes this complicated is not having a separated secrets strategy / migration for this for OSS. It'd be better if we even used a table with globally encrypted values or something so we don't have misleading names depending on the configuration.

@cgardens cgardens self-assigned this Mar 13, 2022
@cgardens
Copy link
Contributor Author

closed by #8898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform team/compose team/platform-move type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants