Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination MSSQL: JDBC connection with advanced params #8785

Closed
lfzuluagah opened this issue Dec 14, 2021 · 12 comments
Closed

Destination MSSQL: JDBC connection with advanced params #8785

lfzuluagah opened this issue Dec 14, 2021 · 12 comments
Labels
area/connectors Connector related issues area/databases community type/enhancement New feature or request

Comments

@lfzuluagah
Copy link

Our customer has an on-prem database in SQLServer with some additional parameters as domain and Integrated Security, in the normal JDBC connectors those parameters are added in an additional parameters string to concatenate with the other parameters

ex
jdbc:jtds:sqlserver://host:port/databasename;domain=mydoman;Integrated Security=true

Describe the solution you’d like

Possibility to add additional parameters in source or destination connections.

it is a blocker to move to airbyte as a data loader tool, analyzing other tools regards to this blocker

thanks for your help in advance

@lfzuluagah lfzuluagah added needs-triage type/enhancement New feature or request labels Dec 14, 2021
@alafanechere alafanechere changed the title Jdbc connection with advanced params Source SQLServer: Jdbc connection with advanced params Dec 14, 2021
@alafanechere alafanechere added area/connectors Connector related issues and removed needs-triage labels Dec 14, 2021
@lfzuluagah
Copy link
Author

@alafanechere what happens if I need to use it as a destination and need the same additional params

@alafanechere alafanechere changed the title Source SQLServer: Jdbc connection with advanced params Source/Destination SQLServer: Jdbc connection with advanced params Dec 15, 2021
@alafanechere alafanechere changed the title Source/Destination SQLServer: Jdbc connection with advanced params Source/Destination SQLServer: JDBC connection with advanced params Dec 15, 2021
@alafanechere
Copy link
Contributor

@lfzuluagah I changed the title to make it clear it also involves destinations. I guess it could be fixed in a PR for both.

@lfzuluagah
Copy link
Author

@lfzuluagah I changed the title to make it clear it also involves destinations. I guess it could be fixed in a PR for both.

thank you, do you know what is the possible ETA for this PR?

@tuliren
Copy link
Contributor

tuliren commented Dec 15, 2021

Postgres also does not allow extra JDBC params. We should add this feature to both Postgres & SQL Server.

Given that the holidays are coming, the ETA is probably mid January 2022.

@lfzuluagah
Copy link
Author

Hi, happy new year, any advance on this PR?

@noahkawasakigoogle
Copy link
Contributor

This is another issue that could be solved by this: #9467

I think the title should be something like "Support Additional Parameters input for JDBC based Sources/Destinations". A lot of customer deployments will need to set additional params to connect to their databases successfully and it would be infeasible for Airbyte to have to add custom UI inputs for every possible value.

@tuliren
Copy link
Contributor

tuliren commented Jan 14, 2022

Hi, happy new year, any advance on this PR?

Unfortunately our team does not have enough bandwidth to work on this. It is in the backlog, but has not been prioritized yet. Currently it's hard to provide an ETA.

@tuliren
Copy link
Contributor

tuliren commented Jan 14, 2022

This is another issue that could be solved by this: #9467

I think the title should be something like "Support Additional Parameters input for JDBC based Sources/Destinations". A lot of customer deployments will need to set additional params to connect to their databases successfully and it would be infeasible for Airbyte to have to add custom UI inputs for every possible value.

Good point. I created an epic issue for aggregation: #9501

@lfzuluagah
Copy link
Author

lfzuluagah commented Jan 26, 2022

@alafanechere @tuliren any advance on this improvement on SQL Server databases??

thanks for your help in advance!!!

@grishick
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @tuliren @edgao @subodh1810

@grishick grishick moved this to Prioritized for scoping in GL Roadmap Apr 27, 2022
@alexandr-shegeda alexandr-shegeda self-assigned this May 19, 2022
@alexandr-shegeda alexandr-shegeda changed the title Source/Destination SQLServer: JDBC connection with advanced params Destination SQLServer: JDBC connection with advanced params May 19, 2022
@alexandr-shegeda alexandr-shegeda removed their assignment May 19, 2022
@alexandr-shegeda alexandr-shegeda changed the title Destination SQLServer: JDBC connection with advanced params Destination MSSQL: JDBC connection with advanced params Aug 29, 2022
@sashaNeshcheret
Copy link
Contributor

Seems it is already resolved by pr and can be closed as duplicate

@grishick grishick closed this as completed Sep 2, 2022
@luke-oa
Copy link

luke-oa commented Jan 19, 2023

Is this actually possible now? jTDS requires a change to the URL itself, not just params appended to the URL string. As far as I can tell it looks as though the base URL string is static and that there's still no way to change it to jdbc:jtds:sqlserver:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/databases community type/enhancement New feature or request
Projects
No open projects
Status: Prioritized for scoping
Development

No branches or pull requests

10 participants