Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fulfillment stream to Shopify source connector #7026

Closed
yuhuishi-convect opened this issue Oct 13, 2021 · 2 comments · Fixed by #7107
Closed

Add fulfillment stream to Shopify source connector #7026

yuhuishi-convect opened this issue Oct 13, 2021 · 2 comments · Fixed by #7107

Comments

@yuhuishi-convect
Copy link
Contributor

Similar to #7025

Tell us about the new connector you’d like to have

  • Which source and which destination?
    This is an enhancement to an existing source connector - Shopify
  • Do you need a specific version of the underlying data source e.g: you specifically need support for an older version of the API or DB?
    NA

Describe the context around this new connector

  • Why do you need this integration? How does your team intend to use the data? This helps us understand the use case.
    We make apps to help Shopify store owners to decide their best inventory target levels at the warehouse locations. However, the normal order stream does not differentiate on where a particular item in an order is fulfilled. Therefore, we cannot count the demands for an item at a particular fulfillment location.
    We use Airbyte for data ingestion. Without the fulfillment stream, such functionalities are impossible.

  • How often do you want to run syncs?
    Daily

  • If this is an API source connector, which entities/endpoints do you need supported?
    Fulfillment endpoint of Shopify admin API - https://shopify.dev/api/admin-rest/2021-10/resources/fulfillmentorder#top

  • If the connector is for a paid service, can we name you as a mutual user when we subscribe for an account? Which company should we name?
    NA

Describe the alternative you are considering or using

What are you considering doing if you don’t have this integration through Airbyte?
Call the Shopify admin API directly on behalf of users

Are you willing to submit a PR?

Yes, with pleasure. But need some help on testing.

@yuhuishi-convect yuhuishi-convect changed the title Add 'fulfillment` stream to Shopify source connector Add fulfillment stream to Shopify source connector Oct 13, 2021
@marcosmarxm
Copy link
Member

thanks @yuhuishi-convect we can help you with testing. Do you have questions about testing locally or in Airbyte CI?

@yuhuishi-convect
Copy link
Contributor Author

yuhuishi-convect commented Oct 15, 2021

thanks @yuhuishi-convect we can help you with testing. Do you have questions about testing locally or in Airbyte CI?

Hello @marcosmarxm , I was following the connector-specific README.md for local integration/acceptance tests.
Though I was getting a few test failures that complaining about getting empty records for a few streams. I assume that is because my development Shopify store does not have those resources populated (E.g., order_risks).

So I tried to trigger integration tests in CI by following https://docs.airbyte.io/connector-development/testing-connectors#2.-requesting-github-pr-integration-test-runs . But my understanding is that community members might not have enough permissions for that.

Shall I ask for a maintainer's help to trigger the testing once a PR is ready for review?

PS: I am working on a similar PR #7063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants