Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bad CSS selector in Airbyte docs #53702

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

ian-at-airbyte
Copy link
Contributor

What

Fixes issues with line spacing between list items.

How

0892361 introduced a poorly thought-out CSS change that caused more issues than it solved. This change reverts it back to its original state.

Review guide

User Impact

List item line spacing will be better and make things more readable.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 9:30pm

@ian-at-airbyte ian-at-airbyte changed the title Remove bad CSS selector Remove bad CSS selector in Airbyte docs Feb 14, 2025
@ian-at-airbyte ian-at-airbyte added area/documentation Improvements or additions to documentation team/documentation labels Feb 14, 2025
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the original reason was for introducing this, but sounds fine to remove :)

@ian-at-airbyte ian-at-airbyte merged commit d642703 into master Feb 14, 2025
25 checks passed
@ian-at-airbyte ian-at-airbyte deleted the docs-fix-list-item-spacing branch February 14, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation team/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants