-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs terraform context #53242
Docs terraform context #53242
Conversation
…ut the JSON version.
…ely changed the TF code sample for running BigQuery as weakly typed. Read through and did a copyedit.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with pull requests your changes make the markdown file much more readable and engaging for new users like me. Now i still have a remark. I would increase the possibility for test driven development in this project and for future contributors. By a bulk test procedure for the most important feature of the project.
Thanks, everyone, for your feedback. I've applied them.
@Charlesnorris509 I did not incorporate your request as it was outside the scope of this particular contribution but I've noted it for the future. |
|
||
```hcl title="main.tf" | ||
resource "airbyte_destination_custom" "my_destination_bigquery_custom" { | ||
configuration = <<-EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to use jsonencode
here instead of a heredoc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I did originally try that and it was my preferred option too, but something about the way Terraform interacts with the API created encoding problems that caused terraform apply
to fail. This seemed to be a problem with BigQuery specifically, not with other destinations, although the exact nature of the issue escapes me now.
Co-authored-by: Alex Buchanan <[email protected]>
What
Expand our Terraform stub article and add new Terraform tutorial. Resolves the docs component of #11525.
How
Expands our stub Terraform topic to be a fully-fledged Terraform tutorial. Includes new discussions and code samples, specifically around the use of JSON strings as alternatives to strongly typed configurations to help deal with Terraform drift.
Not included in this PR are two decisions we need to make about previously created resources:
Both of these resources are out of date compared to this content, and I expect they will be replaced by it. This is a fuller discussion about current challenges and, unlike those other resources, should be technically correct to the latest version of the Terraform provider.
Review guide
For the nice version, just open the linked Vercel build as usual and scroll down to Terraform Provider in the menu.
User Impact
Can this PR be safely reverted and rolled back?