Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source github: don't minify the users field in all any streams #4752

Closed
sherifnada opened this issue Jul 15, 2021 · 2 comments · Fixed by #5156
Closed

Source github: don't minify the users field in all any streams #4752

sherifnada opened this issue Jul 15, 2021 · 2 comments · Fixed by #5156

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Jul 15, 2021

Tell us about the problem you're trying to solve

It would be nice to include the rest of the user information returned by the GitHub API beyond just the user_id. On all streams, but particularly pull requests and commits.
The API endpoint docs are here: https://docs.github.com/en/rest/reference/pulls
And here is an example of the raw data returned by the connector:

{
"url":"https://api.github.com/repos/airbytehq/airbyte/pulls/4646",
"id":686552355,
"node_id":"MDExOlB1bGxSZXF1ZXN0Njg2NTUyMzU1",
"html_url":"#4646",
"diff_url":"https://github.com/airbytehq/airbyte/pull/4646.diff",
"patch_url":"https://github.com/airbytehq/airbyte/pull/4646.patch",
"issue_url":"https://api.github.com/repos/airbytehq/airbyte/issues/4646",
"number":4646,
"state":"closed",
"locked":false,
"title":"0.27.1 Connector Patch Notes",
"body":"## Main Changes\r\n- Adds Connector changelog for the 0.27.1 patch\r\n\r\n## Misc Changes\r\n- Fixes naming for SurveyMonkey and CockroachDB (capitalization matters!)\r\n- Reorganized CockroachDB in the integrations list to be in alphabetical order... very important.",
"created_at":"2021-07-09T07:14:39Z",
"updated_at":"2021-07-09T07:15:29Z",
"closed_at":"2021-07-09T07:15:28Z",
"merged_at":"2021-07-09T07:15:28Z",
"merge_commit_sha":"15971e89b1fb623a006a98489d8aa48cb2de2956",
"draft":false,
"commits_url":"https://api.github.com/repos/airbytehq/airbyte/pulls/4646/commits",
"review_comments_url":"https://api.github.com/repos/airbytehq/airbyte/pulls/4646/comments",
"review_comment_url":"https://api.github.com/repos/airbytehq/airbyte/pulls/comments{/number}",
"comments_url":"https://api.github.com/repos/airbytehq/airbyte/issues/4646/comments",
"statuses_url":"https://api.github.com/repos/airbytehq/airbyte/statuses/0becef350a3da69215644fe38fb2bcd17a32d738",
"head":{
"label":"airbytehq:abhi/indras-net",
"ref":"abhi/indras-net",
"sha":"0becef350a3da69215644fe38fb2bcd17a32d738",
"user_id":59758427,
"repo_id":283046497
},
"base":{
"label":"airbytehq:master",
"ref":"master",
"sha":"db223a4d068b793d0cb054b7fc671b9dc108bfe0",
"user_id":59758427,
"repo_id":283046497
},
"_links":{
"self":{
"href":"https://api.github.com/repos/airbytehq/airbyte/pulls/4646"
},
"html":{
"href":"#4646"
},
"issue":{
"href":"https://api.github.com/repos/airbytehq/airbyte/issues/4646"
},
"comments":{
"href":"https://api.github.com/repos/airbytehq/airbyte/issues/4646/comments"
},
"review_comments":{
"href":"https://api.github.com/repos/airbytehq/airbyte/pulls/4646/comments"
},
"review_comment":{
"href":"https://api.github.com/repos/airbytehq/airbyte/pulls/comments{/number}"
},
"commits":{
"href":"https://api.github.com/repos/airbytehq/airbyte/pulls/4646/commits"
},
"statuses":{
"href":"https://api.github.com/repos/airbytehq/airbyte/statuses/0becef350a3da69215644fe38fb2bcd17a32d738"
}
},
"author_association":"CONTRIBUTOR",
"auto_merge":null,
"active_lock_reason":null,
"user_id":33042053,
"milestone":null,
"assignee":null,
"labels":[
2235194062
],
"assignees":[
],
"requested_reviewers":[
],
"requested_teams":[
],
"_ab_github_repository":"airbytehq/airbyte"
}

Describe the solution you’d like

Include the full user object

Describe the alternative you’ve considered or used

@sherifnada sherifnada added type/enhancement New feature or request area/connectors Connector related issues lang/python labels Jul 15, 2021
@Zirochkaa
Copy link
Contributor

Zirochkaa commented Jul 15, 2021

Should it be user object (and similar to it like author, actor, creator, committer, assignee, assignees, requested_reviewers - they all are the same object) for all streams? Or just for pull_requests stream?

@garden-of-delete
Copy link

garden-of-delete commented Jul 15, 2021

I originated this issue. Ideally, we would include all the data for the user object and similar objects for all streams that provide it. Reason being perhaps you have a contributor who makes issues but not PRs, or the other way around. Would be nice to be able to get info for that user beyond the user_id.

(Also huge thanks for giving the github native connector so much love recently)

@sherifnada sherifnada changed the title Source github: don't minify the users field in the Pull Requests stream Source github: don't minify the users field in all any streams Jul 30, 2021
@sherifnada sherifnada added the priority/medium Medium priority label Jul 30, 2021
@bazarnov bazarnov self-assigned this Aug 3, 2021
@bazarnov bazarnov linked a pull request Aug 3, 2021 that will close this issue
15 tasks
@sherifnada sherifnada moved this to Done in GL Roadmap Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants