Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship modifications for running the Connector Builder Server against local CDK #22093

Closed
clnoll opened this issue Jan 30, 2023 · 1 comment
Closed

Comments

@clnoll
Copy link
Contributor

clnoll commented Jan 30, 2023

Extend the pattern that we use for running the SATs against the local CDK to the Connector Builder server.

Note: this should be done after shipping the SAT updates, in case we want to make slight changes during development.

This will involve:

  1. Adapting the script for creating connector images with the local CDK for the Connector Builder server. The script should take an environment variable that indicates where the CDK is located to future-proof us against the Connector Builder server moving to the Cloud monorepo.
  2. Update the CDK version used by the webapp (see connector builder FE should consume a versioned artifact of declarative_component_schema.yaml #21830).
  3. Creating a gradle task and/or updating the docker-compose.yml to run the Connector Builder server image created by 1.
  4. Creating a gradle task to run tests against the Connector Builder server image created by 1.
  5. Update documentation.

Proof of concept

@clnoll
Copy link
Contributor Author

clnoll commented Feb 14, 2023

When discussing this ticket we decided that there were a few reasons it wasn't high priority:

  1. The Connector Builder server is going to be split into a separate repo, so the flow will necessarily be different.
  2. We're about to launch the Java server for interfacing with the CDK via Docker; we'll have to alter the setup once that's underway.
  3. Testing the Connector Builder server against the local CDK (locally) is not difficult/time-consuming.

Based on that, I'm closing this issue and will open one for running the CB server against a development version of the CDK in CI, which is higher priority.

@clnoll clnoll closed this as completed Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant