Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAT] ignored_fields key for basic read test #21737

Closed
evantahler opened this issue Jan 23, 2023 · 3 comments · Fixed by #22996
Closed

[SAT] ignored_fields key for basic read test #21737

evantahler opened this issue Jan 23, 2023 · 3 comments · Fixed by #22996

Comments

@evantahler
Copy link
Contributor

evantahler commented Jan 23, 2023

Sometimes sources change data in records for each read, like a last_refresh_time column.

See #21419, #21593 and #21775 for examples

@erohmensing
Copy link
Contributor

Grooming -
This is supported for Test full refresh sync - we think we want it for all tests (not just adding it to basic read test)? Is it only necessary for tests with expected records? It's a bit confusing what the support for ignored_fields in test full refresh sync is for

@alafanechere
Copy link
Contributor

It's a bit confusing what the support for ignored_fields in test full refresh sync is for

You are right, I think we could either merge full_refresh test into basic read (or the opposite). In any case, ignored_fields for full refresh and ignored_fields for basic read should serve the same purpose and can be the same pydantic model field. I think we shall add a bypass_reason to explain why we're ignoring this field.

@erohmensing
Copy link
Contributor

I think we shall add a bypass_reason to explain why we're ignoring this field.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants