From bc671b46f03bf01f3ff2faf99b58d0a9e0e6272e Mon Sep 17 00:00:00 2001 From: Denys Davydov Date: Fri, 27 Jan 2023 16:32:42 +0200 Subject: [PATCH] #1347 source amplitude: fix tests --- .../integration_tests/acceptance.py | 13 +++++++++++-- .../source-amplitude/source_amplitude/source.py | 2 +- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/airbyte-integrations/connectors/source-amplitude/integration_tests/acceptance.py b/airbyte-integrations/connectors/source-amplitude/integration_tests/acceptance.py index 480378d7bf203..1302b2f57e10e 100644 --- a/airbyte-integrations/connectors/source-amplitude/integration_tests/acceptance.py +++ b/airbyte-integrations/connectors/source-amplitude/integration_tests/acceptance.py @@ -3,5 +3,14 @@ # -def test_dummy_test(): - assert True +import pytest + +pytest_plugins = ("source_acceptance_test.plugin",) + + +@pytest.fixture(scope="session", autouse=True) +def connector_setup(): + """This fixture is a placeholder for external resources that acceptance test might require.""" + # TODO: setup test dependencies if needed. otherwise remove the TODO comments + yield + # TODO: clean up test dependencies diff --git a/airbyte-integrations/connectors/source-amplitude/source_amplitude/source.py b/airbyte-integrations/connectors/source-amplitude/source_amplitude/source.py index e77f6a3210725..721d2f2ebd36d 100644 --- a/airbyte-integrations/connectors/source-amplitude/source_amplitude/source.py +++ b/airbyte-integrations/connectors/source-amplitude/source_amplitude/source.py @@ -26,7 +26,7 @@ def _convert_auth_to_token(self, username: str, password: str) -> str: def check_connection(self, logger: AirbyteLogger, config: Mapping[str, Any]) -> Tuple[bool, any]: try: auth = TokenAuthenticator(token=self._convert_auth_to_token(config["api_key"], config["secret_key"]), auth_method="Basic") - list(Cohorts(authenticator=auth, data_region=config["data_region"]).read_records(SyncMode.full_refresh)) + list(Cohorts(authenticator=auth, data_region=config.get("data_region", "Standard Server")).read_records(SyncMode.full_refresh)) return True, None except Exception as error: return False, f"Unable to connect to Amplitude API with the provided credentials - {repr(error)}"