From 0113c147c7d1dcdfc5a9137f3ff5d031b3d94655 Mon Sep 17 00:00:00 2001 From: Edward Gao Date: Tue, 4 Feb 2025 08:43:52 -0800 Subject: [PATCH] Destination S3: reenable assume role test; fix file transfer test? (#53147) --- .../destination/s3/S3DestinationAcceptanceTest.kt | 5 ++++- .../destination/s3/S3V2AvroDestinationAcceptanceTest.kt | 5 ----- .../s3/S3V2CsvAssumeRoleDestinationAcceptanceTest.kt | 6 ------ .../destination/s3/S3V2CsvDestinationAcceptanceTest.kt | 5 ----- .../destination/s3/S3V2CsvGzipDestinationAcceptanceTest.kt | 6 ------ .../destination/s3/S3V2JsonlDestinationAcceptanceTest.kt | 5 ----- .../s3/S3V2JsonlGzipDestinationAcceptanceTest.kt | 5 ----- .../destination/s3/S3V2ParquetDestinationAcceptanceTest.kt | 5 ----- 8 files changed, 4 insertions(+), 38 deletions(-) diff --git a/airbyte-cdk/java/airbyte-cdk/s3-destinations/src/testFixtures/kotlin/io/airbyte/cdk/integrations/destination/s3/S3DestinationAcceptanceTest.kt b/airbyte-cdk/java/airbyte-cdk/s3-destinations/src/testFixtures/kotlin/io/airbyte/cdk/integrations/destination/s3/S3DestinationAcceptanceTest.kt index 04bec228cc537..df3eccb808e5a 100644 --- a/airbyte-cdk/java/airbyte-cdk/s3-destinations/src/testFixtures/kotlin/io/airbyte/cdk/integrations/destination/s3/S3DestinationAcceptanceTest.kt +++ b/airbyte-cdk/java/airbyte-cdk/s3-destinations/src/testFixtures/kotlin/io/airbyte/cdk/integrations/destination/s3/S3DestinationAcceptanceTest.kt @@ -805,7 +805,10 @@ protected constructor( ) fail("sync should have failed. Instead got output $destinationOutput") } catch (e: TestHarnessException) { - assertContains(e.outputMessages!![0].trace.error.internalMessage, "File does not exist") + assertContains( + e.outputMessages!![0].trace.error.internalMessage, + "java.io.FileNotFoundException: /staging/files/fakeFile (No such file or directory)" + ) } } diff --git a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2AvroDestinationAcceptanceTest.kt b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2AvroDestinationAcceptanceTest.kt index f35487cb0482d..a11988c9e4cd6 100644 --- a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2AvroDestinationAcceptanceTest.kt +++ b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2AvroDestinationAcceptanceTest.kt @@ -21,9 +21,4 @@ class S3V2AvroDestinationAcceptanceTest : S3BaseAvroDestinationAcceptanceTest() override val baseConfigJson: JsonNode get() = S3V2DestinationTestUtils.baseConfigJsonFilePath - - // Disable these tests until we fix the incomplete stream handling behavior. - override fun testOverwriteSyncMultipleFailedGenerationsFilesPreserved() {} - override fun testOverwriteSyncFailedResumedGeneration() {} - override fun testFakeFileTransfer() {} } diff --git a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvAssumeRoleDestinationAcceptanceTest.kt b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvAssumeRoleDestinationAcceptanceTest.kt index de872f4e49613..f6f533c69a050 100644 --- a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvAssumeRoleDestinationAcceptanceTest.kt +++ b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvAssumeRoleDestinationAcceptanceTest.kt @@ -5,10 +5,8 @@ package io.airbyte.integrations.destination.s3 import com.fasterxml.jackson.databind.JsonNode import io.airbyte.cdk.integrations.destination.s3.S3BaseCsvDestinationAcceptanceTest -import org.junit.jupiter.api.Disabled import org.junit.jupiter.api.Test -@Disabled class S3V2CsvAssumeRoleDestinationAcceptanceTest : S3BaseCsvDestinationAcceptanceTest() { override val imageName: String = "airbyte/destination-s3:dev" override val baseConfigJson: JsonNode @@ -22,8 +20,4 @@ class S3V2CsvAssumeRoleDestinationAcceptanceTest : S3BaseCsvDestinationAcceptanc override fun testFakeFileTransfer() { super.testFakeFileTransfer() } - - // Disable these tests until we fix the incomplete stream handling behavior. - override fun testOverwriteSyncMultipleFailedGenerationsFilesPreserved() {} - override fun testOverwriteSyncFailedResumedGeneration() {} } diff --git a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvDestinationAcceptanceTest.kt b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvDestinationAcceptanceTest.kt index 2215c380a3332..7bc4fa0dc6152 100644 --- a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvDestinationAcceptanceTest.kt +++ b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvDestinationAcceptanceTest.kt @@ -15,9 +15,4 @@ class S3V2CsvDestinationAcceptanceTest : S3BaseCsvDestinationAcceptanceTest() { override val baseConfigJson: JsonNode get() = S3V2DestinationTestUtils.baseConfigJsonFilePath - - // Disable these tests until we fix the incomplete stream handling behavior. - override fun testOverwriteSyncMultipleFailedGenerationsFilesPreserved() {} - override fun testOverwriteSyncFailedResumedGeneration() {} - override fun testFakeFileTransfer() {} } diff --git a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvGzipDestinationAcceptanceTest.kt b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvGzipDestinationAcceptanceTest.kt index 204e0619e551a..3ae927743b74d 100644 --- a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvGzipDestinationAcceptanceTest.kt +++ b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2CsvGzipDestinationAcceptanceTest.kt @@ -15,10 +15,4 @@ class S3V2CsvGzipDestinationAcceptanceTest : S3BaseCsvGzipDestinationAcceptanceT override val baseConfigJson: JsonNode get() = S3V2DestinationTestUtils.baseConfigJsonFilePath - - // Disable these tests until we fix the incomplete stream handling behavior. - override fun testOverwriteSyncMultipleFailedGenerationsFilesPreserved() {} - override fun testOverwriteSyncFailedResumedGeneration() {} - - override fun testFakeFileTransfer() {} } diff --git a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2JsonlDestinationAcceptanceTest.kt b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2JsonlDestinationAcceptanceTest.kt index 2f530805f331c..ea366b08dbaa6 100644 --- a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2JsonlDestinationAcceptanceTest.kt +++ b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2JsonlDestinationAcceptanceTest.kt @@ -15,9 +15,4 @@ class S3V2JsonlDestinationAcceptanceTest : S3BaseJsonlDestinationAcceptanceTest( override val baseConfigJson: JsonNode get() = S3V2DestinationTestUtils.baseConfigJsonFilePath - - // Disable these tests until we fix the incomplete stream handling behavior. - override fun testOverwriteSyncMultipleFailedGenerationsFilesPreserved() {} - override fun testOverwriteSyncFailedResumedGeneration() {} - override fun testFakeFileTransfer() {} } diff --git a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2JsonlGzipDestinationAcceptanceTest.kt b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2JsonlGzipDestinationAcceptanceTest.kt index 2e7b40aab5dc3..56c056287fc55 100644 --- a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2JsonlGzipDestinationAcceptanceTest.kt +++ b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2JsonlGzipDestinationAcceptanceTest.kt @@ -15,9 +15,4 @@ class S3V2JsonlGzipDestinationAcceptanceTest : S3BaseJsonlGzipDestinationAccepta override val baseConfigJson: JsonNode get() = S3V2DestinationTestUtils.baseConfigJsonFilePath - - // Disable these tests until we fix the incomplete stream handling behavior. - override fun testOverwriteSyncMultipleFailedGenerationsFilesPreserved() {} - override fun testOverwriteSyncFailedResumedGeneration() {} - override fun testFakeFileTransfer() {} } diff --git a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2ParquetDestinationAcceptanceTest.kt b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2ParquetDestinationAcceptanceTest.kt index 099d92bb52393..a7a312360d5f0 100644 --- a/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2ParquetDestinationAcceptanceTest.kt +++ b/airbyte-integrations/connectors/destination-s3/src/test-integration-legacy/kotlin/io/airbyte/integrations/destination/s3/S3V2ParquetDestinationAcceptanceTest.kt @@ -73,9 +73,4 @@ class S3V2ParquetDestinationAcceptanceTest : S3BaseParquetDestinationAcceptanceT runSyncAndVerifyStateOutput(config, messages, configuredCatalog, false) } - - // Disable these tests until we fix the incomplete stream handling behavior. - override fun testOverwriteSyncMultipleFailedGenerationsFilesPreserved() {} - override fun testOverwriteSyncFailedResumedGeneration() {} - override fun testFakeFileTransfer() {} }