Fix Proguard rules #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong close and package names were used Closes #71
|
cc @rossbacher |
rossbacher
reviewed
Sep 4, 2018
| -keepclassmembers class * implements com.airbnb.mvrx.MvRxState { | ||
| # Members of the Kotlin data classes used as the state in MvRx are read via Kotlin reflection which cause trouble | ||
| # with Proguard if they are not kept. | ||
| -keepclassmembers class ** implements com.airbnb.mvrx.MvRxState { |
There was a problem hiding this comment.
This change is not really required as from the documentation: For convenience and for backward compatibility, the class name * refers to any class, irrespective of its package.
However it makes sense to only use one notation inside one config.
rossbacher
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong close and package names were used
Closes #71