From 57fcdfaec5bd29ea453ea1cdd2d0275edd751848 Mon Sep 17 00:00:00 2001 From: codeif Date: Tue, 19 Dec 2017 15:59:54 +0800 Subject: [PATCH 1/5] Function web.run_app add param access_log_class --- aiohttp/web.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/aiohttp/web.py b/aiohttp/web.py index 199319a25aa..9ba2e7d39f8 100644 --- a/aiohttp/web.py +++ b/aiohttp/web.py @@ -7,7 +7,7 @@ from . import (web_exceptions, web_fileresponse, web_middlewares, web_protocol, web_request, web_response, web_runner, web_server, - web_urldispatcher, web_ws) + web_urldispatcher, web_ws, helpers) from .http import HttpVersion # noqa from .log import access_logger from .web_app import Application # noqa @@ -38,12 +38,14 @@ def run_app(app, *, host=None, port=None, path=None, sock=None, shutdown_timeout=60.0, ssl_context=None, - print=print, backlog=128, access_log_format=None, - access_log=access_logger, handle_signals=True): + print=print, backlog=128, access_log_class=helpers.AccessLogger, + access_log_format=None, access_log=access_logger, + handle_signals=True): """Run an app locally""" loop = asyncio.get_event_loop() runner = AppRunner(app, handle_signals=handle_signals, + access_log_class=access_log_class, access_log_format=access_log_format, access_log=access_log) From e110faf153a1a8ec1251ee4e48e0cd1779b4b461 Mon Sep 17 00:00:00 2001 From: codeif Date: Tue, 19 Dec 2017 16:51:55 +0800 Subject: [PATCH 2/5] Docs of web.run_app add param access_log_class --- docs/web_reference.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/web_reference.rst b/docs/web_reference.rst index f30a44f438c..bd2bb627a4f 100644 --- a/docs/web_reference.rst +++ b/docs/web_reference.rst @@ -2270,6 +2270,7 @@ Utilities .. function:: run_app(app, *, host=None, port=None, path=None, \ sock=None, shutdown_timeout=60.0, \ ssl_context=None, print=print, backlog=128, \ + access_log_class=aiohttp.helpers.AccessLogger, \ access_log_format=None, \ access_log=aiohttp.log.access_logger, \ handle_signals=True) @@ -2330,6 +2331,10 @@ Utilities system will allow before refusing new connections (``128`` by default). + :param access_log_class: class for `access_logger`. Default: + :data:`aiohttp.helpers.AccessLogger`. + Must to be a subclass of :class:`aiohttp.abc.AbstractAccessLogger`. + :param access_log: :class:`logging.Logger` instance used for saving access logs. Use ``None`` for disabling logs for sake of speedup. From 73f3c48e34f7af11657e2e6894a81ee2f3483cb6 Mon Sep 17 00:00:00 2001 From: codeif Date: Tue, 19 Dec 2017 17:46:33 +0800 Subject: [PATCH 3/5] Add changelog and contributor --- CHANGES/2615.feature | 1 + CONTRIBUTORS.txt | 1 + 2 files changed, 2 insertions(+) create mode 100644 CHANGES/2615.feature diff --git a/CHANGES/2615.feature b/CHANGES/2615.feature new file mode 100644 index 00000000000..1afdeea8ce5 --- /dev/null +++ b/CHANGES/2615.feature @@ -0,0 +1 @@ +Add param access_log_class to web.run_app function diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt index b57b76924db..f60411588f9 100644 --- a/CONTRIBUTORS.txt +++ b/CONTRIBUTORS.txt @@ -202,6 +202,7 @@ Will McGugan Willem de Groot Wilson Ong Wei Lin +Weiwei Wang Yannick Koechlin Yannick PĂ©roux Yegor Roganov From 0de370fee9a3fc0ff8785798616195e6d23895f2 Mon Sep 17 00:00:00 2001 From: codeif Date: Thu, 21 Dec 2017 11:37:21 +0800 Subject: [PATCH 4/5] make isort --- aiohttp/web.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/aiohttp/web.py b/aiohttp/web.py index 9ba2e7d39f8..87bdb89586e 100644 --- a/aiohttp/web.py +++ b/aiohttp/web.py @@ -5,9 +5,9 @@ from collections import Iterable from importlib import import_module -from . import (web_exceptions, web_fileresponse, web_middlewares, web_protocol, - web_request, web_response, web_runner, web_server, - web_urldispatcher, web_ws, helpers) +from . import (helpers, web_exceptions, web_fileresponse, web_middlewares, + web_protocol, web_request, web_response, web_runner, web_server, + web_urldispatcher, web_ws) from .http import HttpVersion # noqa from .log import access_logger from .web_app import Application # noqa From 759d0fbed55574b7afbe3f058f6b139e5e74e4f4 Mon Sep 17 00:00:00 2001 From: codeif Date: Thu, 21 Dec 2017 12:02:12 +0800 Subject: [PATCH 5/5] Update docs/web_reference.rst --- docs/web_reference.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/web_reference.rst b/docs/web_reference.rst index bd2bb627a4f..1926806f8df 100644 --- a/docs/web_reference.rst +++ b/docs/web_reference.rst @@ -2346,6 +2346,9 @@ Utilities :param bool handle_signals: override signal TERM handling to gracefully exit the application. + .. versionadded:: 3.0 + + Support *access_log_class* parameter. Constants ---------