Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBO report: handle error with 'pubDate' #184

Closed
aih opened this issue Feb 16, 2021 · 0 comments
Closed

CBO report: handle error with 'pubDate' #184

aih opened this issue Feb 16, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@aih
Copy link
Collaborator

aih commented Feb 16, 2021

The CBO report scraper and loader in load_cbo (now merged to main, and mostly working) often has an error with the pubdate:

-------- ERROR -------- 'pubDate'

This prevents many (especially earlier) CBO reports from being loaded. I believe the error is on this line, currently line 118 of cbo.py:

pub_date = cbo_data['pubDate']

This should probably be changed to a 'get' with a default (e.g. cbo_data.get('pubDate', '')), and then handle the downstream effects of not having a proper pubDate.

@aih aih added the bug Something isn't working label Mar 9, 2021
@ayeshamk ayeshamk closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants