Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lowerCase conversion optional #245

Open
josephrexme opened this issue Sep 12, 2017 · 4 comments
Open

Make lowerCase conversion optional #245

josephrexme opened this issue Sep 12, 2017 · 4 comments

Comments

@josephrexme
Copy link

This forces every input to be converted to lower case but I need the correct letter casing from the input. Can we take this out completely or make it optional like unicodePunctuation

msg = msg.toLowerCase()

@josephrexme
Copy link
Author

Is there any risk posed by upper case letters? Why can't there be case sensitive inputs?

@dcsan
Copy link
Contributor

dcsan commented Sep 13, 2017

I think we discussed this originally and @kirsle felt it would be too demanding on users to have case sensitive required. we had problems around having to artificially type things like i am here with I in lowercase.

#143

@josephrexme
Copy link
Author

@dcsan with the changes on my PR referenced here #246 , we wouldn't be forcing case sensitive inputs on users. It only gets added when the author wants it. I.e new Rivescript({caseSensitive: true}) without that, everything converts to lower case. I just can't tell why the tests are failing on that. I'd write a test for it but it is quite hard to understand how the tests are arranged per feature and the test errors are so long with no detail or proper trace

@josephrexme
Copy link
Author

@kirsle I got the tests passing on the PR for this. Is it something that will be considered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants