fix: Token provider getHighestLiquidityPair #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monilpat
requested changes
Nov 23, 2024
| currentMarketCap > highestMarketCap) | ||
| ) { | ||
| return currentPair; | ||
| return dexData.pairs.sort((a, b) => { |
There was a problem hiding this comment.
Looks like the same code in two places can we create a function and reuse it?
There was a problem hiding this comment.
they are being used by different token providers in each chain plugin, right now the only common place is core and maybe not a good place to add it. For now I thinks its fine like this, maybe creating a service for proving tokens would be better place for this
There was a problem hiding this comment.
Yeah makes sense feel free to just add an issue or TODO comment so it doesn't get lost. LGTM otherwise thanks so much!
monilpat
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#467
Risks
Background
What does this PR do?
Fixes bug in getHighestLiquidityPair token providers
What kind of change is this?
Bug Fix
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps