Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish an official Docker Image in ghcr. #876

Open
luisalrp opened this issue Dec 6, 2024 · 15 comments
Open

Publish an official Docker Image in ghcr. #876

luisalrp opened this issue Dec 6, 2024 · 15 comments
Labels
enhancement New feature or request

Comments

@luisalrp
Copy link
Contributor

luisalrp commented Dec 6, 2024

Would be really useful to have an official Docker Image to pull.

Describe the solution you'd like

A Github Action that creates the Docker Image with each release, tag it properly and upload it to ghcr or dockerhub.

Describe alternatives you've considered

An alternative is really ugly. It is being aware of each release and do it manually or use some cicd to do it.

Thanks!

@luisalrp luisalrp added the enhancement New feature or request label Dec 6, 2024
@v1xingyue
Copy link
Contributor

#889

@luisalrp
Copy link
Contributor Author

Hey @v1xingyue,

Thanks for the PR. I noticed there was a release, but I can't see the package, while if I go to the Create and publish a Docker image action, I can see they were ok. Not sure whats happening. Maybe its a rights problem?
image

Thanks!

@v1xingyue
Copy link
Contributor

Ya @luisalrp I checked the log action running. It tells image has been pushed:

image

But When I pull one image from my cloud server.
It tells no unauthorized :

image

I'm not sure, is it the problem of permission?

@v1xingyue
Copy link
Contributor

v1xingyue commented Dec 18, 2024

image

Also github shows we have one public image. But we can't see. Maybe we should check the settings about package.

image
This is one of my image settings,maybe our package is private.

Or maybe we should change our org package settings:

https://github.com/organizations/ai16z/settings/packages

@luisalrp
Copy link
Contributor Author

Yeah, I think its something about visibility (sorry for using rights instead of visibility). When I tried to pull it, I got the same unauthorized as you. Not sure how to solve it.

I went to Solve Problems in Work with containers registry, and there is nothing about it.

I asked xAi and it says that packages by default sets to private.

I hope it helps. Thanks!

@v1xingyue
Copy link
Contributor

v1xingyue commented Dec 18, 2024

I think we may change this package to public ? @lalalune

@luisalrp
Copy link
Contributor Author

luisalrp commented Dec 19, 2024

Hey, @v1xingyue, @lalalune;

I created a PR to change package visibility when creating new releases, so no need to manually change visibility on future releases. I'm happy to have contributed a little bit.

Best, Luis.

@v1xingyue
Copy link
Contributor

v1xingyue commented Dec 19, 2024

Wow thanks that's so cool, Wait for next release.

@v1xingyue
Copy link
Contributor

v1xingyue commented Dec 22, 2024

Hey, @v1xingyue, @lalalune;

I created a PR to change package visibility when creating new releases, so no need to manually change visibility on future releases. I'm happy to have contributed a little bit.

Best, Luis.

Hey, your pr about change visibility runs failed , it returns 404

https://github.com/elizaOS/eliza/actions/runs/12452080982/job/34760652944#step:7:1

@luisalrp
Copy link
Contributor Author

Sorry for that. Then it can be done only by config. Configuring a package's access control and visibility.

I created a PR to delete the non working task.

@v1xingyue
Copy link
Contributor

Ya that's really true. So let's change the package visibility @lalalune

@luisalrp
Copy link
Contributor Author

Hey frens!

Any ETA for this? It is a pity that being done, it can't be used due to package visibility config. @v1xingyue, do you know if there is someone else with the rights to change package visibility? I understand that with Christmas and road show in Asia it is being busy days for @lalalune 😊

Best, Luis!

@luisalrp
Copy link
Contributor Author

luisalrp commented Jan 8, 2025

Maybe @shakkernerd can change package visibility? I've seen publishing the releases 😃

@Kevin-Mok
Copy link

Also hoping to try using the Docker package soon!

@shakkernerd
Copy link
Member

Maybe @shakkernerd can change package visibility? I've seen publishing the releases 😃

I will take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants