Skip to content

Commit d044084

Browse files
authored
chore(log_to_metric transform): Add Cargo feature for the transform (vectordotdev#18337)
The `log_to_metric` transform was missing a corresponding Cargo feature. Therefore, when compiling Vector with a reduced set of features, this transform was always included even if not requested. This is the only transform that was still missing a Cargo feature. The previous attempt incorrectly tried to feature-gate the `parser` module in `internal_events`. Instead, this commit allows for the `parser` module imports to be left unused when not required. The test configuration in the `api` module was also missing a dependency on `transforms-log_to_metric`. Signed-off-by: Hugo Hromic <[email protected]>
1 parent b982a74 commit d044084

File tree

4 files changed

+9
-0
lines changed

4 files changed

+9
-0
lines changed

Cargo.toml

+4
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,7 @@ transforms-logs = [
580580
"transforms-aws_ec2_metadata",
581581
"transforms-dedupe",
582582
"transforms-filter",
583+
"transforms-log_to_metric",
583584
"transforms-lua",
584585
"transforms-metric_to_log",
585586
"transforms-pipelines",
@@ -592,6 +593,7 @@ transforms-logs = [
592593
transforms-metrics = [
593594
"transforms-aggregate",
594595
"transforms-filter",
596+
"transforms-log_to_metric",
595597
"transforms-lua",
596598
"transforms-metric_to_log",
597599
"transforms-pipelines",
@@ -604,6 +606,7 @@ transforms-aggregate = []
604606
transforms-aws_ec2_metadata = ["dep:arc-swap"]
605607
transforms-dedupe = ["dep:lru"]
606608
transforms-filter = []
609+
transforms-log_to_metric = []
607610
transforms-lua = ["dep:mlua", "vector-core/lua"]
608611
transforms-metric_to_log = []
609612
transforms-pipelines = ["transforms-filter", "transforms-route"]
@@ -848,6 +851,7 @@ shutdown-tests = ["api", "sinks-blackhole", "sinks-console", "sinks-prometheus",
848851
cli-tests = ["sinks-blackhole", "sinks-socket", "sources-demo_logs", "sources-file"]
849852
vector-api-tests = [
850853
"sources-demo_logs",
854+
"transforms-log_to_metric",
851855
"transforms-remap",
852856
"sinks-blackhole"
853857
]

src/api/tap.rs

+1
Original file line numberDiff line numberDiff line change
@@ -415,6 +415,7 @@ async fn tap_handler(
415415
test,
416416
feature = "sinks-blackhole",
417417
feature = "sources-demo_logs",
418+
feature = "transforms-log_to_metric",
418419
feature = "transforms-remap",
419420
))]
420421
mod tests {

src/internal_events/mod.rs

+3
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ mod journald;
7676
mod kafka;
7777
#[cfg(feature = "sources-kubernetes_logs")]
7878
mod kubernetes_logs;
79+
#[cfg(feature = "transforms-log_to_metric")]
7980
mod log_to_metric;
8081
mod logplex;
8182
#[cfg(feature = "sinks-loki")]
@@ -213,6 +214,7 @@ pub(crate) use self::journald::*;
213214
pub(crate) use self::kafka::*;
214215
#[cfg(feature = "sources-kubernetes_logs")]
215216
pub(crate) use self::kubernetes_logs::*;
217+
#[cfg(feature = "transforms-log_to_metric")]
216218
pub(crate) use self::log_to_metric::*;
217219
#[cfg(feature = "sources-heroku_logs")]
218220
pub(crate) use self::logplex::*;
@@ -224,6 +226,7 @@ pub(crate) use self::lua::*;
224226
pub(crate) use self::metric_to_log::*;
225227
#[cfg(feature = "sources-nginx_metrics")]
226228
pub(crate) use self::nginx_metrics::*;
229+
#[allow(unused_imports)]
227230
pub(crate) use self::parser::*;
228231
#[cfg(feature = "sources-postgresql_metrics")]
229232
pub(crate) use self::postgresql_metrics::*;

src/transforms/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ pub mod aws_ec2_metadata;
1212
pub mod dedupe;
1313
#[cfg(feature = "transforms-filter")]
1414
pub mod filter;
15+
#[cfg(feature = "transforms-log_to_metric")]
1516
pub mod log_to_metric;
1617
#[cfg(feature = "transforms-lua")]
1718
pub mod lua;

0 commit comments

Comments
 (0)