Skip to content

Commit 70632b7

Browse files
authored
chore(ci): Remove path filter that runs all integration tests (vectordotdev#17908)
Currently this causes all integration tests to run on common dependabot changes to `lib/vector-core/Cargo.toml` even though those changes are likely to be very low risk. These tests also fail due to dependabot not having access to secrets but that is being addressed separately; the primary argument in this PR is that the tests aren't needed in the PR, just the merge queue, for changes to `Cargo.toml` due to the low risk. I had originally just wanted to exclude only `lib/vector-core/Cargo.toml` but this wasn't possible due to a lack of support by the paths-filter action (dorny/paths-filter#106). Upon reflection, I think it is is unlikely that core changes will cause integration test failures that don't also cause other test failures so my proposal is that we just rely on the merge queue to catch that scenario. If we find it to be the contrary, we can add it back. Signed-off-by: Jesse Szwedko <[email protected]> Signed-off-by: Jesse Szwedko <[email protected]>
1 parent 251c4c4 commit 70632b7

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

vdev/src/commands/integration/ci_paths.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ pub struct Cli {}
1111

1212
impl Cli {
1313
pub fn exec(&self) -> Result<()> {
14-
// changes to vector-core should test all integrations
14+
// placeholder for changes that should run all integration tests
1515
println!("all-int:");
16-
println!("- \"lib/vector-core/**\"");
1716

1817
// paths for each integration are defined in their respective config files.
1918
for (integration, config) in IntegrationTestConfig::collect_all()? {

0 commit comments

Comments
 (0)