feat(ruby): updating semantic-release-rubygem-with-pkg-root for releasing rubygems #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadnassri
requested changes
Sep 10, 2020
Dockerfile
Outdated
|
|
||
| COPY package.json package-lock.json index.js /action/ | ||
| RUN npm ci --only=prod | ||
|
|
||
| RUN useradd -ms /bin/bash deploy | ||
| USER deploy |
There was a problem hiding this comment.
this does nothing in GitHub actions as they are always run as root
There was a problem hiding this comment.
Without it bundler will complain about being run with root. But gem will still build, it really just ensures that Gem lock will have the latest version as the gem itself.
[8:17:38 PM] [semantic-release] [semantic-release-rubygem-with-pkg-root] › ℹ Updating lock file with command `bundle install`
Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
installing your bundle as root will break this application for all non-root
users on this machine.
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ruby and bundler for building ruby based gems.